Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small refactoring to support 'HttpError'. #98

Merged
merged 1 commit into from
May 1, 2022
Merged

Conversation

alonadam
Copy link
Contributor

No description provided.

@github-actions
Copy link

github-actions bot commented Apr 27, 2022

Unit Test Results

    1 files  ±0    13 suites  ±0   12m 12s ⏱️ - 4m 36s
320 tests ±0  320 ✔️ +2  0 💤 ±0  0  - 2 

Results for commit 0366222. ± Comparison against base commit 5936442.

♻️ This comment has been updated with latest results.

@AsafMah
Copy link
Contributor

AsafMah commented Apr 27, 2022

MM you might want to try embedding Error inside HttpError, and then you can save (some of) the hassle

@alonadam alonadam force-pushed the HttpErrorRefactoring branch 2 times, most recently from ca8b845 to fb96a2d Compare April 28, 2022 15:11
@alonadam alonadam force-pushed the HttpErrorRefactoring branch from fb96a2d to 0366222 Compare April 28, 2022 15:27
@codecov
Copy link

codecov bot commented Apr 28, 2022

Codecov Report

Merging #98 (0366222) into master (3c014ca) will decrease coverage by 0.10%.
The diff coverage is 39.39%.

@@            Coverage Diff             @@
##           master      #98      +/-   ##
==========================================
- Coverage   50.88%   50.77%   -0.11%     
==========================================
  Files          41       41              
  Lines        4500     4553      +53     
==========================================
+ Hits         2290     2312      +22     
- Misses       2052     2081      +29     
- Partials      158      160       +2     
Impacted Files Coverage Δ
kusto/conn.go 0.00% <0.00%> (ø)
kusto/data/errors/errors.go 59.81% <0.00%> (-6.35%) ⬇️
kusto/ingest/internal/resources/resources.go 62.88% <70.58%> (+1.15%) ⬆️
kusto/ingest/internal/conn/conn.go 64.60% <100.00%> (ø)
kusto/ingest/streaming.go 80.64% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5936442...0366222. Read the comment docs.

@alonadam alonadam requested a review from AsafMah April 28, 2022 15:34
Copy link
Contributor

@AsafMah AsafMah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alonadam alonadam merged commit 6614580 into master May 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants