Refactor TableClient to use Azure Data Tables SDK
#278
+146
−170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replace deprecated `storage` package with `aztables` for table client operations. - Update `NewTableClient` to initialize an `aztables.Client` using the new SDK. - Modify `Read` and `Write` methods to utilize `aztables` API. - Add support for context propagation in `Read` and `Write` methods. - Serialize and deserialize entity data with JSON for compatibility with `aztables`. - Remove outdated table service and entity handling logic.
There was a problem hiding this comment.
Copilot reviewed 4 out of 7 changed files in this pull request and generated no comments.
Files not reviewed (3)
- azkustodata/go.mod: Language not supported
- azkustoingest/go.mod: Language not supported
- go.work.sum: Language not supported
Comments suppressed due to low confidence (2)
azkustoingest/internal/status/status_table_client.go:62
- The comment is incorrect. It should say 'Write writes a table record containing ingestion status.'
// Write reads a table record cotaining ingestion status.
azkustoingest/result.go:70
- Using
context.Background()here might not be ideal. Consider passing the context from the caller to ensure proper context propagation.
err = client.Write(context.Background(), r.record.IngestionSourceID.String(), r.record.ToMap())
yogilad
approved these changes
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
storagepackage withaztablesfor table client operations.NewTableClientto initialize anaztables.Clientusing the new SDK.ReadandWritemethods to utilizeaztablesAPI.ReadandWritemethods.aztables.Added
Changed
Fixed
Removed
Security