Fix process crashes in iothubtransport_mqtt_common #875
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
devdoc
folder and added or modified requirements.master
branch.master
branch prior to submission and re-merged as needed after I took any feedback.Reference/Link to the issue solved with this PR (if any)
#842
Description of the problem
Retry action returned by the retry control logic is not being handled in
iothubtransport_mqtt_common.c
.RETRY_ACTION_RETRY_LATER
action is not being handled, which results in a crash. On recieving,RETRY_ACTION_STOP_RETRYING
the return value should be non-zero.Description of the solution
Setting return value of internal function
InitializeConnection
as failure upon recieving retry action asRETRY_ACTION_RETRY_LATER
orRETRY_ACTION_STOP_RETRYING
.