Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix process crashes in iothubtransport_mqtt_common #875

Merged
merged 2 commits into from
Feb 26, 2019

Conversation

jitin17
Copy link
Contributor

@jitin17 jitin17 commented Feb 21, 2019

Checklist

  • I have read the [contribution guidelines] (https://github.com/Azure/azure-iot-sdk-c/blob/master/.github/CONTRIBUTING.md).
  • [] I added or modified the existing tests to cover the change (we do not allow our test coverage to go down).
  • If this is a modification that impacts the behavior of a public API
    • I edited the corresponding document in the devdoc folder and added or modified requirements.
  • I submitted this PR against the correct branch:
    • This pull-request is submitted against the master branch.
    • I have merged the latest master branch prior to submission and re-merged as needed after I took any feedback.
    • I have squashed my changes into one with a clear description of the change.

Reference/Link to the issue solved with this PR (if any)

#842

Description of the problem

Retry action returned by the retry control logic is not being handled in iothubtransport_mqtt_common.c. RETRY_ACTION_RETRY_LATER action is not being handled, which results in a crash. On recieving, RETRY_ACTION_STOP_RETRYING the return value should be non-zero.

Description of the solution

Setting return value of internal function InitializeConnection as failure upon recieving retry action as RETRY_ACTION_RETRY_LATER or RETRY_ACTION_STOP_RETRYING.

Copy link
Contributor

@jebrando jebrando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants