Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: cleanup / look and feel #452

Closed
wants to merge 2 commits into from
Closed

cmake: cleanup / look and feel #452

wants to merge 2 commits into from

Conversation

obastemur
Copy link
Contributor

@obastemur obastemur commented Apr 10, 2018

Checklist

  • I have read the [contribution guidelines] (https://github.com/Azure/azure-iot-sdk-c/blob/master/.github/CONTRIBUTING.md).
  • I added or modified the existing tests to cover the change (we do not allow our test coverage to go down).
  • If this is a modification that impacts the behavior of a public API
    • I edited the corresponding document in the devdoc folder and added or modified requirements.
  • I submitted this PR against the correct branch:
    • This pull-request is submitted against the master branch.
    • I have merged the latest master branch prior to submission and re-merged as needed after I took any feedback.
    • I have squashed my changes into one with a clear description of the change.

Reference/Link to the issue solved with this PR (if any)

Description of the problem

Nothing really

Description of the solution

Cleanup / look & feel

make space after `#` and `if` are matching and fix spacing
set(WINDOWS TRUE)
elseif(CMAKE_SYSTEM_NAME STREQUAL "Linux")
# making a global variable to know if we are on linux, windows, or macosx.
if (CMAKE_SYSTEM_NAME STREQUAL "Windows")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will be kept in since other folks might be using it in private forks.

@ewertons
Copy link
Contributor

ewertons commented May 23, 2018

Your change has been merged into the master branch (6e11063)

Thanks for contributing to the Azure IoT SDK!

@ewertons
Copy link
Contributor

@obastemur, thank you for your contribution to our open-sourced project! Please help us improve by filling out this 2-minute customer satisfaction survey.

@ewertons ewertons closed this May 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants