Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IoTHubClient_LL_UploadToBlob_NotifyCompletion to use empty string when responseMessage is NULL (gh2554) #2555

Merged
merged 1 commit into from
Jan 9, 2024

Conversation

ewertons
Copy link
Contributor

@ewertons ewertons commented Jan 8, 2024

Checklist

  • I have read the [contribution guidelines] (https://github.com/Azure/azure-iot-sdk-c/blob/main/.github/CONTRIBUTING.md).
  • I added or modified the existing tests to cover the change (we do not allow our test coverage to go down).
  • If this is a modification that impacts the behavior of a public API
    • I edited the corresponding document in the devdoc folder and added or modified requirements.
  • I submitted this PR against the correct branch:
    • This pull-request is submitted against the main branch.
    • I have merged the latest main branch prior to submission and re-merged as needed after I took any feedback.
    • I have squashed my changes into one with a clear description of the change.

Reference/Link to the issue solved with this PR (if any)

#2554

Description of the problem

#2554

Description of the solution

Use empty string as format argument in STRING_construct_sprintf instead of NULL.

Note: Test not added because STRING_construct_sprintf is not mocked in that unit test set.

@ewertons ewertons enabled auto-merge (squash) January 9, 2024 17:06
@ewertons ewertons merged commit 0609954 into main Jan 9, 2024
37 checks passed
@ewertons ewertons deleted the ewertons/gh2554 branch January 9, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants