-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Propagate file upload timeout #2439
Conversation
@@ -343,7 +343,7 @@ TEST_FUNCTION(Blob_UploadMultipleBlocksFromSasUri_with_NULL_SasUri_fails) | |||
unsigned int httpResponse = HTTP_OK; | |||
|
|||
///act | |||
BLOB_RESULT result = Blob_UploadMultipleBlocksFromSasUri(NULL, FileUpload_GetData_Callback, &context, &httpResponse, testValidBufferHandle, NULL, NULL, NULL); | |||
BLOB_RESULT result = Blob_UploadMultipleBlocksFromSasUri(NULL, FileUpload_GetData_Callback, &context, &httpResponse, testValidBufferHandle, NULL, NULL, NULL, 0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add a test where we're passing a non-zero timeout here and make sure that the HTTPAPI_SetOption() is being executed. See the blocks in Blob_UploadMultipleBlocksFromSasUri_various_sizes_happy_path_Impl
like say below to give a flavor of how this works with optional certs.
if (certificate != NULL)
{
STRICT_EXPECTED_CALL(HTTPAPIEX_SetOption(IGNORED_PTR_ARG, "TrustedCerts", IGNORED_PTR_ARG));
}
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added!
This is failing because of a CI bug introduced by a new policy. |
Checklist
devdoc
folder and added or modified requirements.main
branch.main
branch prior to submission and re-merged as needed after I took any feedback.Reference/Link to the issue solved with this PR (if any)
Description of the problem
Setting the option 'OPTION_BLOB_UPLOAD_TIMEOUT_SECS' only persists for step 1 and 3 of the file upload (telling IoTHub there's an upload and telling IoTHub the upload finished)
Description of the solution
This PR makes sure the timeout gets set in step 2 as well (the upload of the file)