Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added subscription_error_count reset / AMQP IOTHUB_CLIENT_CONNECTION_QUOTA_EXCEEDED #2267

Merged
merged 14 commits into from
Mar 29, 2022
Merged

added subscription_error_count reset / AMQP IOTHUB_CLIENT_CONNECTION_QUOTA_EXCEEDED #2267

merged 14 commits into from
Mar 29, 2022

Conversation

ericwolz
Copy link
Contributor

@ericwolz ericwolz commented Mar 29, 2022 •
edited
Loading

Checklist

  • I have read the [contribution guidelines] (https://github.com/Azure/azure-iot-sdk-c/blob/main/.github/CONTRIBUTING.md).
  • I added or modified the existing tests to cover the change (we do not allow our test coverage to go down).
  • If this is a modification that impacts the behavior of a public API
    • I edited the corresponding document in the devdoc folder and added or modified requirements.
  • I submitted this PR against the correct branch:
    • This pull-request is submitted against the main branch.
    • I have merged the latest main branch prior to submission and re-merged as needed after I took any feedback.
    • I have squashed my changes into one with a clear description of the change.

Reference/Link to the issue solved with this PR (if any)

Description of the problem

Description of the solution

@ericwolz
Copy link
Contributor Author

#2249

@danewalton-msft
Copy link
Member

I'm guessing tests for this would be difficult....

CIPop
CIPop reviewed Mar 29, 2022
View reviewed changes
Copy link
Member

@CIPop CIPop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code should look for other AMQP error codes.
Missing UT.

@ericwolz ericwolz merged commit cb8ef05 into main Mar 29, 2022
@ericwolz ericwolz deleted the ericwol/basic_hub2 branch March 29, 2022 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CIPop CIPop CIPop left review comments

@danewalton-msft danewalton-msft danewalton-msft approved these changes

@ewertons ewertons ewertons left review comments

@jspaith jspaith Awaiting requested review from jspaith

@momuno momuno Awaiting requested review from momuno

@preethi826 preethi826 Awaiting requested review from preethi826

@vaavva vaavva Awaiting requested review from vaavva vaavva is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ericwolz @danewalton-msft @CIPop @ewertons