Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test fixes #2240

Merged
merged 5 commits into from
Feb 23, 2022
Merged

Test fixes #2240

merged 5 commits into from
Feb 23, 2022

Conversation

CIPop
Copy link
Member

@CIPop CIPop commented Feb 22, 2022 •
edited
Loading

  • Remove test publishing from jobs not running tests.
  • Fixing IoT Twin SFC test memory leak.
  • Permanently disabling some UTs for Provisioning Service Client.
  • Removing OpenSSL Valgrind workaround.
  • Adding E2E test registry manager retries.

danewalton-msft
danewalton-msft reviewed Feb 22, 2022
View reviewed changes
build/.vsts-ci.yml
@@ -172,7 +164,7 @@ jobs:
sudo -E ./jenkins/ubuntu_clang.sh
displayName: 'Build'
- script: |
cd cmake && sudo -E ../build_all/linux/run_tests.sh run_valgrind
cd cmake && sudo -E ../build_all/linux/run_tests.sh
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does this run valgrind tests though?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh wait that's right I separated the build and test run steps. This is just for the openssl workaround

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. The previous run shows all SKUs ran valgrind correctly. The script was only adding the OpenSSL workaround. CMake generation is controlling Valgrind enable/disable.

image

@CIPop
Copy link
Member Author

CIPop commented Feb 22, 2022

Added E2E retries - the previous run shows instability when updating a module that was just created: (1 test failed / 2,591).

@CIPop CIPop enabled auto-merge (squash) February 23, 2022 00:07
@CIPop CIPop merged commit ecfe487 into Azure:main Feb 23, 2022
ericwolz
ericwolz reviewed Feb 23, 2022
View reviewed changes
testtools/iothub_test/src/iothub_account.c
break;
}

LogError("Updating device/module %s/%s failed with error %d. Sleeping %d milliseconds", deviceToProvision->deviceId, deviceToProvision->moduleId, result, TEST_SLEEP_BETWEEN_CREATION_FAILURES_MSEC);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LogInfo ?

ericwolz
ericwolz reviewed Feb 23, 2022
View reviewed changes
testtools/iothub_test/src/iothub_account.c

while (true)
{
LogInfo("Attempting to update test module on %s/%s", deviceToProvision->deviceId, deviceToProvision->moduleId);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

too verbose?

jspaith added a commit that referenced this pull request Mar 4, 2022
@jspaith @ericwolz
@momuno @danewalton-msft @CIPop @nkgami
Merge latest main into PnP staging branch (#2254)
2599750 
* longhaul: handle IoTHubDeviceTwin_GetTwin network error (#2189)

* handle IoTHubDeviceTwin_GetTwin network error

* pr feedback

* Fix valgrind issues in E2E tests (#2192)

* handle IoTHubDeviceTwin_GetTwin network error

* pr feedback

* Fix valgrind issues in E2E tests

* update RIoT to update bouncycastle dependency (#2197)

* Bump version from 1.8.0 to 1.9.0. Add LTS Table entry for LTS_01_2022_Ref01 (#2199)

* update RIoT to update bouncycastle dependency (#2202)

* update Component Governance for pip dependencies (#2203)

* add codeowner file (#2204)

* Add vaavva to CODEOWNERS (#2208)

* Refactor of device twin e2e tests (#2158)

* shutdown of AMQP - logging causes crash due to status_description is NULL (#2210)

#2200

* Update CMake Linux samples to remove warnings (#2212)

* add ios notice for authentication (#2217)

* Add macros includes to the build include directories (#2218)

* added telemetry timeout filter to statistics (#2221)

* added telemetry timeout filter to statistics
Added network tracing for get twin tests

* fix build break

* Ericwol/longhaul3 (#2223)

* added telemetry timeout filter to statistics
Added network tracing for get twin tests

* fix build break

* pr feedback

* Improve blob unit test performance (#2225)

* Added documentation on device application CMAKE (#2224)

* Added documentation on device application CMAKE

* pr feedback

* rename cmake doc

* remove old hsm devices from iot hub (#2232)

* remove dash from device model ID (#2237)

* Adding X509 PEM support for Provisioning Client (#2229)

* Adding DPS X509 public APIs. Splitting RIOT vs X509 tests.

* Adding UT for x509 HSM.

* Adding E2E tests.

* Adding OpenSSL ENGINE tests for DPS.

* Adding DevOps infra.

* Doc changes.

* Apply suggestions from code review

Co-authored-by: Eric Wolz <ericwol@microsoft.com>

* Fixing cmake integration issue

* Fixing vsts job name.

* Fixing Windows build. Removing DPS TPM and SAS for now.

* Adding HSM type configurations for all HSMs.

* Enabling DPS client by default.

* Addressing feedback around const and malloc/free.

* Fixing prov service client comment bug. Disabling prov_client on XCode.

* Fixing x509 sample when using trusted certificates.

* Fixing options test

* Adding test result publishing to all VSTS jobs.

* Changing test scripts to output ctest Test.xml logs.

* Disabling Provisioning Service Client tests failing on OSX.

* Fixing build scripts and test yaml definition.

* Apply suggestions from code review

Co-authored-by: Dane Walton <dawalton@microsoft.com>

* Resolving PR comments.

* Disabling two SFC tests failing leak checking. Tracked by #2238

Co-authored-by: Eric Wolz <ericwol@microsoft.com>
Co-authored-by: Dane Walton <dawalton@microsoft.com>

* Test fixes (#2240)

* Removing test publishing for jobs not running tests.

* Fixing Twin SFC test memory leak.

* Permanently disabling Provisioning Service Client for Apple.

* Removing the OpenSSL Valgrind workaround.

* Adding E2E service client module creation/update retries.

* Add more e2e tests service client retries (#2241)

* Adding e2e test method invoke retry.

* Removing unused 'edison' cmake config.

* Fixing Windows build.

* Increasing the DPS E2E randomized start delay between 0 and 1min.

* Addressing PR feedback.

* Updating Parson to v1.3.1. (#2242)

* Test stabilization (#2245)

* Increasing methods E2E device connect timeout.

* Initializing seed for Prov E2E random back-off algorithm.

* Update setting-up-vcpkg documentation (#2246)

* Adding retries to the DPS test. (#2250)

* Adding retries to the DPS test.

* Apply suggestions from code review

Co-authored-by: Eric Wolz <ericwol@microsoft.com>

Co-authored-by: Eric Wolz <ericwol@microsoft.com>

* Adding -Wstrict-prototypes gate validation (#2251)

* Partial fixes for -Wstrict-prototypes

* Adding strict-prototypes gate check.

* Updating submodules.

* Update CMakeLists.txt

Co-authored-by: Eric Wolz <ericwol@microsoft.com>

Co-authored-by: Eric Wolz <ericwol@microsoft.com>

* Add instruction to sign certs with intermediate CA (#2186)

* Add instruction to sign certs with intermediate cA

Default method "create_device_certificate" will create a device certificate which is chained up to the root certificate directly.
In group enrollment scenario of Device Provisioning Service, users may want the device certs to be chained up to the intermediate certificate. So "create_device_certificate_from_intermediate" should be noted.

* Adding multi-level client certificate documentation

* Addressing PR feedback

Co-authored-by: CIPop <Cristian.Pop@microsoft.com>

* Fix merge typo && fix issue found by more gate tests brought in by merge

Co-authored-by: Eric Wolz <ericwol@microsoft.com>
Co-authored-by: Mollie Munoz <mollie.munoz@microsoft.com>
Co-authored-by: Dane Walton <dane.walton@microsoft.com>
Co-authored-by: Cristian Pop <CIPop@users.noreply.github.com>
Co-authored-by: Dane Walton <dawalton@microsoft.com>
Co-authored-by: Hiroki Nakagami <nkgami@gamid.net>
Co-authored-by: CIPop <Cristian.Pop@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericwolz ericwolz ericwolz left review comments

@danewalton-msft danewalton-msft danewalton-msft approved these changes

@ewertons ewertons Awaiting requested review from ewertons ewertons is a code owner

@jspaith jspaith Awaiting requested review from jspaith

@momuno momuno Awaiting requested review from momuno

@preethi826 preethi826 Awaiting requested review from preethi826

@vaavva vaavva Awaiting requested review from vaavva vaavva is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CIPop @danewalton-msft @ericwolz