Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

send IOTHUB_CLIENT_CONNECTION_COMMUNICATION_ERROR of failed PUBACK DC messages #2078

Merged
merged 5 commits into from
Sep 13, 2021

Conversation

ericwolz
Copy link
Contributor

@ericwolz ericwolz commented Sep 9, 2021

Checklist

  • I have read the [contribution guidelines] (https://github.com/Azure/azure-iot-sdk-c/blob/master/.github/CONTRIBUTING.md).
  • I added or modified the existing tests to cover the change (we do not allow our test coverage to go down).
  • If this is a modification that impacts the behavior of a public API
    • I edited the corresponding document in the devdoc folder and added or modified requirements.
  • I submitted this PR against the correct branch:
    • This pull-request is submitted against the master branch.
    • I have merged the latest master branch prior to submission and re-merged as needed after I took any feedback.
    • I have squashed my changes into one with a clear description of the change.

Reference/Link to the issue solved with this PR (if any)

Description of the problem

Fix for issue #1255 was partially correct. There was a missing connection status callback in the affected code, however the status to be raised should be COMMUNICATION_ERROR, not RETRY_EXPIRED. RETRY_EXPIRED must only be raised on the code path that actually deals with retry policy checks.

Description of the solution

Replace the connection status callback value of RETRY_EXPIRED by COMMUNICATION_ERROR.

@ewertons ewertons requested a review from momuno September 13, 2021 16:35
@ericwolz ericwolz merged commit 1a1ff8c into master Sep 13, 2021
@ericwolz ericwolz deleted the ericwol/mqtt__message_puback branch September 13, 2021 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants