send IOTHUB_CLIENT_CONNECTION_COMMUNICATION_ERROR of failed PUBACK DC messages #2078
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
devdoc
folder and added or modified requirements.master
branch.master
branch prior to submission and re-merged as needed after I took any feedback.Reference/Link to the issue solved with this PR (if any)
Description of the problem
Fix for issue #1255 was partially correct. There was a missing connection status callback in the affected code, however the status to be raised should be COMMUNICATION_ERROR, not RETRY_EXPIRED. RETRY_EXPIRED must only be raised on the code path that actually deals with retry policy checks.
Description of the solution
Replace the connection status callback value of RETRY_EXPIRED by COMMUNICATION_ERROR.