Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update submodules #1583

Merged
merged 1 commit into from
Jul 9, 2020
Merged

Update submodules #1583

merged 1 commit into from
Jul 9, 2020

Conversation

ewertons
Copy link
Contributor

@ewertons ewertons commented Jul 8, 2020 •
edited by CIPop
Loading

Checklist

  • I have read the [contribution guidelines] (https://github.com/Azure/azure-iot-sdk-c/blob/master/.github/CONTRIBUTING.md).
  • I added or modified the existing tests to cover the change (we do not allow our test coverage to go down).
  • If this is a modification that impacts the behavior of a public API
    • I edited the corresponding document in the devdoc folder and added or modified requirements.
  • I submitted this PR against the correct branch:
    • This pull-request is submitted against the master branch.
    • I have merged the latest master branch prior to submission and re-merged as needed after I took any feedback.
    • I have squashed my changes into one with a clear description of the change.

Reference/Link to the issue solved with this PR (if any)

This is happening at commit eb836ef1af71515b5644f40cb2a163389a250801

Description of the problem

Description of the solution

CIPop
CIPop approved these changes Jul 8, 2020
View reviewed changes
Copy link
Member

@CIPop CIPop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @ewertons !

@ewertons ewertons merged commit 6668a08 into master Jul 9, 2020
@ewertons ewertons deleted the subup-202007081636 branch July 9, 2020 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danewalton-msft danewalton-msft danewalton-msft approved these changes

@CIPop CIPop CIPop approved these changes

@momuno momuno Awaiting requested review from momuno

@hihigupt hihigupt Awaiting requested review from hihigupt

@ericwolz ericwolz Awaiting requested review from ericwolz

@wduraes wduraes Awaiting requested review from wduraes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ewertons @CIPop @danewalton-msft