Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove incorrect const qualifier in serializer methodreturn #1304

Merged
merged 1 commit into from
Nov 8, 2019

Conversation

ewertons
Copy link
Contributor

@ewertons ewertons commented Nov 8, 2019

Checklist

  • I have read the [contribution guidelines] (https://github.com/Azure/azure-iot-sdk-c/blob/master/.github/CONTRIBUTING.md).
  • I added or modified the existing tests to cover the change (we do not allow our test coverage to go down).
  • If this is a modification that impacts the behavior of a public API
    • I edited the corresponding document in the devdoc folder and added or modified requirements.
  • I submitted this PR against the correct branch:
    • This pull-request is submitted against the master branch.
    • I have merged the latest master branch prior to submission and re-merged as needed after I took any feedback.
    • I have squashed my changes into one with a clear description of the change.

Reference/Link to the issue solved with this PR (if any)

Description of the problem

Compilation fails on Mac OS with:

Testing with xcodebuild.
-> AzureIoTHubClient (1.3.6-public-preview-c)
- WARN | source: Git sources should specify a tag.
- ERROR | xcodebuild: Returned an unsuccessful exit code.
- ERROR | xcodebuild: AzureIoTHubClient/serializer/src/methodreturn.c:70:41: error: cannot assign to non-static data member 'statusCode' with const-qualified type 'const int'
- NOTE | xcodebuild: AzureIoTHubClient/inc/methodreturn.h:16:51: note: non-static data member 'statusCode' declared const here

Description of the solution

Remove the const qualifiers.

@jbobotek jbobotek assigned jbobotek and unassigned jbobotek Nov 8, 2019
@jbobotek jbobotek self-requested a review November 8, 2019 22:57
@ewertons ewertons merged commit 241b66e into master Nov 8, 2019
@ewertons ewertons deleted the FixForiOS branch January 16, 2020 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants