Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Cascade Lake SKUs to HanaInstance #36

Merged
merged 1 commit into from
Nov 13, 2019
Merged

Add Cascade Lake SKUs to HanaInstance #36

merged 1 commit into from
Nov 13, 2019

Conversation

lagalbra
Copy link
Contributor 

az extension remove -n sap-hana
python3 setup.py bdist_wheel -b bdist -d ./dist/ --universal
az extension add --source dist/sap_hana-0.5.6-py2.py3-none-any.whl
az hanainstance -h
az hanainstance create -h

AprilZhaoWY
AprilZhaoWY reviewed Nov 12, 2019
View reviewed changes
azext_hanaonazure/modules_sdk/version.py
@@ -9,5 +9,5 @@
# regenerated.
# --------------------------------------------------------------------------

VERSION = "0.9.0"
VERSION = "0.11.0"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is it a jump from 9 to 11? Is it something regenerated on our behalf?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is generated on our behalf; it had been bumped to 0.10.0 before, but not updated in this CLI extension codebase.

@lagalbra lagalbra merged commit a4a152f into master Nov 13, 2019
@lagalbra lagalbra deleted the lagalbra/add-cascade-lake-skus branch November 13, 2019 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rukawata rukawata rukawata approved these changes

@pabowers pabowers pabowers approved these changes

@AprilZhaoWY AprilZhaoWY AprilZhaoWY approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@lagalbra @rukawata @pabowers @AprilZhaoWY