NodeJs v10 support #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pragnagopa
reviewed
Jun 11, 2018
tsconfig.json
Outdated
| @@ -4,6 +4,7 @@ | |||
| "target": "es6", | |||
| "noImplicitAny": false, | |||
| "strict": true, | |||
| "strictNullChecks": false, | |||
There was a problem hiding this comment.
should we keep the default as it might be safer?
pragnagopa
reviewed
Jun 11, 2018
pragnagopa
approved these changes
Jun 11, 2018
|
Just curious - why does the upgrade to node 10 result in a breaking change in the proto file? |
|
We need to upgrade protobufjs to be able to use node 10, and upgrading protobufjs resulted in a few breaking changes. One of them is that we used to call the package "FunctionRpc" and the service "FunctionRpc" in our proto file. This now doesn't compile from type errors due to the naming conflict |
|
got it, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expands supported versions to be 8.x and 10.x
Note: test failures still need to be addressed when using v10.0.0 from this issue: nodejs/node#20258
Must consume latest proto file before pulling into functions-host: Azure/azure-functions-language-worker-protobuf@a42a580
Resolves #66