Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KeyVaultSecretsRepository will now page through all secrets in Key Vault #6682

Merged
merged 1 commit into from
Sep 30, 2020
Merged

KeyVaultSecretsRepository will now page through all secrets in Key Vault #6682

merged 1 commit into from
Sep 30, 2020

Conversation

gzuber
Copy link
Member

@gzuber gzuber commented Sep 22, 2020 •
edited
Loading

Issue describing the changes in this PR

resolves #6031

Pull request checklist

  • My changes do not require documentation changes
    • Otherwise: Documentation issue linked to PR
  • My changes should not be added to the release notes for the next release
    • Otherwise: I've added my notes to release_notes.md
  • My changes do not need to be backported to a previous version
    • Otherwise: Backport tracked by issue/PR #issue_or_pr
  • I have added all required tests (Unit tests, E2E tests)

@gzuber gzuber requested a review from alrod September 22, 2020 01:20
alrod
alrod previously approved these changes Sep 29, 2020
View reviewed changes
Copy link
Member

@alrod alrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with a comment.

@gzuber gzuber force-pushed the gzuber/6031-keyvault-regen branch from aacec96 to 4385f3f Compare September 30, 2020 18:33
alrod
alrod previously approved these changes Sep 30, 2020
View reviewed changes
@gzuber gzuber force-pushed the gzuber/6031-keyvault-regen branch from 4385f3f to df229cd Compare September 30, 2020 19:29
@gzuber gzuber merged commit 497bd19 into dev Sep 30, 2020
@gzuber gzuber deleted the gzuber/6031-keyvault-regen branch September 30, 2020 20:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yojagad yojagad yojagad approved these changes

@alrod alrod alrod left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

All Function Keys Regenerate Constantly
3 participants
@gzuber @alrod @yojagad