Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade Python 3.8 to 3.10 #1463

Merged
merged 19 commits into from
Mar 28, 2023
Merged

Upgrade Python 3.8 to 3.10 #1463

merged 19 commits into from
Mar 28, 2023

Conversation

pamelafox
Copy link
Member

Python 3.9 was released 2020-10-05 and has been supported by Azure App Service and Azure Functions for a while, so it should be fine to update the samples to all use 3.9.

We could almost update them to 3.10, but we're waiting for that to be out of preview for Azure Functions:
https://learn.microsoft.com/en-us/azure/azure-functions/functions-reference-python?tabs=asgi%2Capplication-level&pivots=python-mode-configuration#python-version

The template-tests job should be kicked off for this to confirm no issues.

@ghost ghost assigned pamelafox Jan 27, 2023
@jongio
Copy link
Member

jongio commented Jan 30, 2023

Can you see if you can find out when 3.10 will be out of preview?

@pamelafox
Copy link
Member Author

The CI failed on files I did not change:

Run cspell lint '**/*' --config ./.vscode/cspell.yaml --relative --no-progress
./schemas/v1.0/azure.yaml.json:159:30 - Unknown word (postdeploy)
./schemas/v1.0/azure.yaml.json:16[4](https://github.com/Azure/azure-dev/actions/runs/4057804310/jobs/6983992673#step:5:5):30 - Unknown word (prerestore)
./schemas/v1.0/azure.yaml.json:169:30 - Unknown word (postrestore)
./schemas/v1.0/azure.yaml.json:179:30 - Unknown word (postpackage)
./schemas/v1.0/azure.yaml.json:2[5](https://github.com/Azure/azure-dev/actions/runs/4057804310/jobs/6983992673#step:5:6)3:18 - Unknown word (preprovision)
./schemas/v1.0/azure.yaml.json:258:18 - Unknown word (postprovision)
./schemas/v1.0/azure.yaml.json:2[6](https://github.com/Azure/azure-dev/actions/runs/4057804310/jobs/6983992673#step:5:7)3:18 - Unknown word (preinfracreate)
./schemas/v1.0/azure.yaml.json:268:18 - Unknown word (postinfracreate)
./schemas/v1.0/azure.yaml.json:2[7](https://github.com/Azure/azure-dev/actions/runs/4057804310/jobs/6983992673#step:5:8)3:1[8](https://github.com/Azure/azure-dev/actions/runs/4057804310/jobs/6983992673#step:5:9) - Unknown word (preinfradelete)
./schemas/v1.0/azure.yaml.json:278:18 - Unknown word (postinfradelete)
./schemas/v1.0/azure.yaml.json:283:18 - Unknown word (predown)
./schemas/v1.0/azure.yaml.json:288:18 - Unknown word (postdown)
./schemas/v1.0/azure.yaml.json:2[9](https://github.com/Azure/azure-dev/actions/runs/4057804310/jobs/6983992673#step:5:10)3:18 - Unknown word (preup)
./schemas/v1.0/azure.yaml.json:298:18 - Unknown word (postup)
./schemas/v1.0/azure.yaml.json:308:18 - Unknown word (postdeploy)
./schemas/v1.0/azure.yaml.json:3[13](https://github.com/Azure/azure-dev/actions/runs/4057804310/jobs/6983992673#step:5:14):[18](https://github.com/Azure/azure-dev/actions/runs/4057804310/jobs/6983992673#step:5:19) - Unknown word (prerestore)
./schemas/v1.0/azure.yaml.json:318:18 - Unknown word (postrestore)

@rajeshkamal5050
Copy link
Contributor

The CI failed on files I did not change:

Run cspell lint '**/*' --config ./.vscode/cspell.yaml --relative --no-progress
./schemas/v1.0/azure.yaml.json:159:30 - Unknown word (postdeploy)
./schemas/v1.0/azure.yaml.json:16[4](https://github.com/Azure/azure-dev/actions/runs/4057804310/jobs/6983992673#step:5:5):30 - Unknown word (prerestore)
./schemas/v1.0/azure.yaml.json:169:30 - Unknown word (postrestore)
./schemas/v1.0/azure.yaml.json:179:30 - Unknown word (postpackage)
./schemas/v1.0/azure.yaml.json:2[5](https://github.com/Azure/azure-dev/actions/runs/4057804310/jobs/6983992673#step:5:6)3:18 - Unknown word (preprovision)
./schemas/v1.0/azure.yaml.json:258:18 - Unknown word (postprovision)
./schemas/v1.0/azure.yaml.json:2[6](https://github.com/Azure/azure-dev/actions/runs/4057804310/jobs/6983992673#step:5:7)3:18 - Unknown word (preinfracreate)
./schemas/v1.0/azure.yaml.json:268:18 - Unknown word (postinfracreate)
./schemas/v1.0/azure.yaml.json:2[7](https://github.com/Azure/azure-dev/actions/runs/4057804310/jobs/6983992673#step:5:8)3:1[8](https://github.com/Azure/azure-dev/actions/runs/4057804310/jobs/6983992673#step:5:9) - Unknown word (preinfradelete)
./schemas/v1.0/azure.yaml.json:278:18 - Unknown word (postinfradelete)
./schemas/v1.0/azure.yaml.json:283:18 - Unknown word (predown)
./schemas/v1.0/azure.yaml.json:288:18 - Unknown word (postdown)
./schemas/v1.0/azure.yaml.json:2[9](https://github.com/Azure/azure-dev/actions/runs/4057804310/jobs/6983992673#step:5:10)3:18 - Unknown word (preup)
./schemas/v1.0/azure.yaml.json:298:18 - Unknown word (postup)
./schemas/v1.0/azure.yaml.json:308:18 - Unknown word (postdeploy)
./schemas/v1.0/azure.yaml.json:3[13](https://github.com/Azure/azure-dev/actions/runs/4057804310/jobs/6983992673#step:5:14):[18](https://github.com/Azure/azure-dev/actions/runs/4057804310/jobs/6983992673#step:5:19) - Unknown word (prerestore)
./schemas/v1.0/azure.yaml.json:318:18 - Unknown word (postrestore)

@wbreza can you take a look?

wbreza
wbreza approved these changes Jan 31, 2023
View reviewed changes
Copy link
Contributor

@wbreza wbreza left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Looks like their are some failing pipelines, but once those have been resolved this should be good to go.
Once you rebase the checks below should just go green.

@pamelafox
Copy link
Member Author

@wbreza Merged main and the CI checks are happy campers now!

@pamelafox pamelafox closed this Feb 9, 2023
@pamelafox pamelafox reopened this Feb 9, 2023
@pamelafox
Copy link
Member Author

(Sigh accidentally clicked close, re-opened now!)

@pamelafox
Copy link
Member Author

@jongio The Python functions team announced yesterday that 3.10 is generally available!
https://azure.microsoft.com/en-us/updates/generally-available-azure-functions-support-for-python-310/
Shall I update to 3.10?

@jongio
Copy link
Member

jongio commented Feb 17, 2023

Yeah, thanks.

@pamelafox pamelafox changed the title Upgrade Python 3.8 to 3.9 Upgrade Python 3.8 to 3.10 Feb 18, 2023
@pamelafox
Copy link
Member Author

@jongio Updated to 3.10 and updated images to be language-specific (across all the languages), per my comment.

@pamelafox pamelafox requested a review from jongio February 21, 2023 19:12
@vhvb1989
Copy link
Member

/azp run azure-dev - repoman

@vhvb1989
Copy link
Member

@jongio ping

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vhvb1989
Copy link
Member

This is currently blocked by: #1237

Deploying with pyhon is falling on CI due to symlink. Should get unblock after: #1764

@vhvb1989
Copy link
Member

/azp run azure-dev - repoman

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vhvb1989 vhvb1989 mentioned this pull request Mar 23, 2023
Closed
@vhvb1989
Copy link
Member

/azp run azure-dev - repoman

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vhvb1989
Copy link
Member

/azp run azure-dev - repoman

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vhvb1989
Copy link
Member

/azp run azure-dev - repoman

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vhvb1989
Copy link
Member

/azp run azure-dev - repoman

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@vhvb1989
Copy link
Member

/azp run azure-dev - repoman

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-sdk
Copy link
Collaborator

Repoman Generation Results

Repoman pushed changes to remotes for the following projects:

Project: todo-csharp-cosmos-sql

Remote: azure-samples-staging

Branch: pr/1463

You can initialize this project with:

azd init -t Azure-Samples/todo-csharp-cosmos-sql -b pr/1463

View Changes | Compare Changes

Project: todo-csharp-sql-swa-func

Remote: azure-samples-staging

Branch: pr/1463

You can initialize this project with:

azd init -t Azure-Samples/todo-csharp-sql-swa-func -b pr/1463

View Changes | Compare Changes

Project: todo-csharp-sql

Remote: azure-samples-staging

Branch: pr/1463

You can initialize this project with:

azd init -t Azure-Samples/todo-csharp-sql -b pr/1463

View Changes | Compare Changes

Project: todo-java-mongo-aca

Remote: azure-samples-staging

Branch: pr/1463

You can initialize this project with:

azd init -t Azure-Samples/todo-java-mongo-aca -b pr/1463

View Changes | Compare Changes

Project: todo-java-mongo

Remote: azure-samples-staging

Branch: pr/1463

You can initialize this project with:

azd init -t Azure-Samples/todo-java-mongo -b pr/1463

View Changes | Compare Changes

Project: todo-nodejs-mongo-aca

Remote: azure-samples-staging

Branch: pr/1463

You can initialize this project with:

azd init -t Azure-Samples/todo-nodejs-mongo-aca -b pr/1463

View Changes | Compare Changes

Project: todo-nodejs-mongo-aks

Remote: azure-samples-staging

Branch: pr/1463

You can initialize this project with:

azd init -t Azure-Samples/todo-nodejs-mongo-aks -b pr/1463

View Changes | Compare Changes

Project: todo-nodejs-mongo-swa-func

Remote: azure-samples-staging

Branch: pr/1463

You can initialize this project with:

azd init -t Azure-Samples/todo-nodejs-mongo-swa-func -b pr/1463

View Changes | Compare Changes

Project: todo-nodejs-mongo

Remote: azure-samples-staging

Branch: pr/1463

You can initialize this project with:

azd init -t Azure-Samples/todo-nodejs-mongo -b pr/1463

View Changes | Compare Changes

Project: todo-nodejs-mongo-terraform

Remote: azure-samples-staging

Branch: pr/1463

You can initialize this project with:

azd init -t Azure-Samples/todo-nodejs-mongo-terraform -b pr/1463

View Changes | Compare Changes

Project: todo-python-mongo-aca

Remote: azure-samples-staging

Branch: pr/1463

You can initialize this project with:

azd init -t Azure-Samples/todo-python-mongo-aca -b pr/1463

View Changes | Compare Changes

Project: todo-python-mongo-swa-func

Remote: azure-samples-staging

Branch: pr/1463

You can initialize this project with:

azd init -t Azure-Samples/todo-python-mongo-swa-func -b pr/1463

View Changes | Compare Changes

Project: todo-python-mongo

Remote: azure-samples-staging

Branch: pr/1463

You can initialize this project with:

azd init -t Azure-Samples/todo-python-mongo -b pr/1463

View Changes | Compare Changes

Project: todo-python-mongo-terraform

Remote: azure-samples-staging

Branch: pr/1463

You can initialize this project with:

azd init -t Azure-Samples/todo-python-mongo-terraform -b pr/1463

View Changes | Compare Changes

@vhvb1989 vhvb1989 merged commit f4a9f65 into Azure:main Mar 28, 2023
@pamelafox pamelafox deleted the upgrade39 branch March 28, 2023 23:05
@weikanglim weikanglim mentioned this pull request Dec 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wbreza wbreza wbreza approved these changes

@vhvb1989 vhvb1989 vhvb1989 approved these changes

@jongio jongio Awaiting requested review from jongio jongio is a code owner

Assignees

@pamelafox pamelafox

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pamelafox @jongio @rajeshkamal5050 @vhvb1989 @azure-sdk @wbreza