-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NPM Lite] Support Network Policies Through CNS #3287
Open
rejain456
wants to merge
16
commits into
master
Choose a base branch
from
jainriya/npmliteCNIchange
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rejain456
changed the title
[NPM Lite] Default Deny CNI Changes
[NPM Lite] Support Default Deny Network Policies Through CNS
Jan 10, 2025
tamilmani1989
changed the title
[NPM Lite] Support Default Deny Network Policies Through CNS
[NPM Lite] Support Network Policies Through CNS
Jan 10, 2025
paulyufan2
reviewed
Jan 10, 2025
can we add comment to the description that this change is only applied on windows |
paulyufan2
reviewed
Jan 10, 2025
tamilmani1989
previously approved these changes
Jan 10, 2025
paulyufan2
previously approved these changes
Jan 10, 2025
/azp run Azure Container Networking PR |
Azure Pipelines successfully started running 1 pipeline(s). |
rejain456
dismissed stale reviews from paulyufan2 and tamilmani1989
via
January 10, 2025 23:15
ab735cc
/azp run Azure Container Networking PR |
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
As part of adding default deny so pods can't communicate with one another when network policies are not present, this pr is part 3 which updates the cni code, retrieving the default deny acl from cns and creating HNS endpoints of the ACL's for the pods
Issue Fixed:
Requirements:
Notes: