Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CNS] add config snapshot event metrics at an interval #3140

Merged
merged 9 commits into from
Nov 21, 2024
Merged

[CNS] add config snapshot event metrics at an interval #3140

merged 9 commits into from
Nov 21, 2024

Conversation

jackieluc
Copy link
Member

@jackieluc jackieluc commented Nov 12, 2024 •
edited
Loading

Reason for Change:
Inspired by @ramiro-gamarra's PR to emit config snapshots at an interval, we should do the same for CNS for a consistent view for both components.

Issue Fixed:

Requirements:

Notes:

@jackieluc jackieluc added cns Related to CNS. telemetry labels Nov 12, 2024
@jackieluc jackieluc requested a review from a team as a code owner November 12, 2024 22:44
@jackieluc jackieluc requested a review from neaggarwMS November 12, 2024 22:44
@jackieluc
Copy link
Member Author

/azp run Azure Container Networking PR

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jackieluc jackieluc changed the title [CNS] add CNS config snapshot event metrics at an interval [CNS] add config snapshot event metrics at an interval Nov 12, 2024
rbtr
rbtr reviewed Nov 13, 2024
View reviewed changes
cns/configuration/cns_config.json Show resolved Hide resolved
cns/configuration/configuration.go Outdated Show resolved Hide resolved
cns/metric/configsnapshot.go Show resolved Hide resolved
ramiro-gamarra
ramiro-gamarra reviewed Nov 13, 2024
View reviewed changes
cns/metric/configsnapshot.go Show resolved Hide resolved
cns/metric/configsnapshot.go Show resolved Hide resolved
cns/metric/configsnapshot_test.go Outdated Show resolved Hide resolved
rbtr
rbtr reviewed Nov 19, 2024
View reviewed changes
cns/metric/configsnapshot.go Outdated Show resolved Hide resolved
@jackieluc
Copy link
Member Author

/azp run Azure Container Networking PR

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jackieluc jackieluc enabled auto-merge November 19, 2024 23:51
@jackieluc jackieluc added this pull request to the merge queue Nov 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 20, 2024
@jackieluc jackieluc added this pull request to the merge queue Nov 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Nov 20, 2024
@jackieluc jackieluc added this pull request to the merge queue Nov 20, 2024
Merged via the queue into Azure:master with commit bf2b3d2 Nov 21, 2024
14 checks passed
@jackieluc jackieluc deleted the jackieluc/config-snapshot-metric branch November 21, 2024 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msvik msvik msvik left review comments

@timraymond timraymond timraymond left review comments

@rbtr rbtr rbtr approved these changes

@neaggarwMS neaggarwMS Awaiting requested review from neaggarwMS neaggarwMS is a code owner automatically assigned from Azure/acn-cns-reviewers

@ramiro-gamarra ramiro-gamarra Awaiting requested review from ramiro-gamarra

Assignees
No one assigned
Labels
cns Related to CNS. telemetry
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jackieluc @timraymond @rbtr @msvik @ramiro-gamarra