ci: Add exit code capture for PR pipeline #3125
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2069bf0 to
675f067
Compare
paulyufan2
previously approved these changes
Nov 8, 2024
2bf4d95 to
df2f6a1
Compare
df2f6a1 to
7d8720f
Compare
paulyufan2
approved these changes
Nov 12, 2024
|
/azp Run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Certain PR pipeline steps did not capture bash error codes correctly or overwrote them with successive calls.
In fixing this I also captured a missed input for the
cilium-test.yamltemplate that also required fixes.Issue Fixed:
Requirements:
Notes:
Instead of adding set -e everywhere we can also split out deleting namespaces, assigning variables, ect.
Exit codes get overwritten when any command is ran after a test i.e
make test-validate-state | go test ...