fix: update pipeline to handle an extra character 'v' in version tag #3089
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Full Pipeline run with private fork images: |
|
/azp run Azure Container Networking PR |
camrynl
approved these changes
Oct 28, 2024
|
/azp run Azure Container Networking PR |
jpayne3506
approved these changes
Oct 28, 2024
There was a problem hiding this comment.
Lgtm, @santhoshmprabhu will be adding the node-subnet template changes as part of #3083.
🚀
|
/azp run Azure Container Networking PR |
|
/azp list |
|
/run Azure Container Networking PR |
|
/azp list |
|
/azp |
|
/azp list |
4 tasks
4 tasks
jpayne3506
pushed a commit
that referenced
this pull request
Oct 31, 2024
…3089) * fix: update pipeline to handle v in version tag * chore: empty commit for pipeline run
4 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 1, 2024
* fix: update pipeline to handle an extra character 'v' in version tag (#3089) * fix: update pipeline to handle v in version tag * chore: empty commit for pipeline run * ci: update CILIUM_VERSION_TAG to CILIUM_VERSION_TAG_V1_5 --------- Co-authored-by: Santhosh Prabhu <6684582+santhoshmprabhu@users.noreply.github.com>
4 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Nov 20, 2024
…eline (#3158) ci: add in 3089 to hubble block
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
ACN pipelines used Cilium version tags that didn't include the letter 'v'. This PR updates the pipelines to handle private fork version tags, which include the letter 'v'. This will allow us to set ADO pipeline variables to point to ACN private fork images for Cilium.
Issue Fixed:
Lack of support for ACN Cilium private fork images
Requirements:
Notes: