-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add dhcp discover packet to linux swiftv2 to ensure mappings exist for dns #2989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timraymond
reviewed
Sep 6, 2024
QxBytes
force-pushed
the
alew/dhcp
branch
2 times, most recently
from
September 6, 2024 22:46
8f8075b
to
469ef99
Compare
timraymond
reviewed
Sep 9, 2024
tamilmani1989
previously approved these changes
Sep 9, 2024
/azp run Azure Container Networking PR |
Azure Pipelines successfully started running 1 pipeline(s). |
QxBytes
force-pushed
the
alew/dhcp
branch
3 times, most recently
from
September 9, 2024 23:48
7220bea
to
e683b1d
Compare
/azp run Azure Container Networking PR |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run Azure Container Networking PR |
Azure Pipelines successfully started running 1 pipeline(s). |
tamilmani1989
approved these changes
Sep 10, 2024
/azp run Azure Container Networking PR |
Azure Pipelines successfully started running 1 pipeline(s). |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
In linux swiftv2, nslookup using the wireserver may fail in certain scenarios. The theory is that this is because the host does not have mappings/state for the dns on the secondary/delegated nics (eth1). To ensure that state is created, we send a dhcp discover packet through the delegated nic (eth1) so the mappings are created. Any offers returned are ignored.
Issue Fixed:
See above.
Requirements:
Notes:
We assume that epInfo.IfName contains the actual interface name of the nic! The dhcp discover packet MUST get a successful offer or the add call will fail. If in swiftv2 we have multiple nics, we send the dhcp request for each one and all must succeed or the add call will fail. Ensure the ifName is in epInfo.ifName
Should affect Swiftv2 Linux only.
Reviewer(s):
Tested: