Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[fix] ci: cluster deletion for swiftv2 #2986

Merged
merged 1 commit into from
Sep 13, 2024
Merged

[fix] ci: cluster deletion for swiftv2 #2986

merged 1 commit into from
Sep 13, 2024

Conversation

jpayne3506
Copy link
Contributor

Reason for Change:

Fixes the delete cluster stage by targeting the different subs. Additionally, amplifies the resource group deletion by targeting the correct region based on the env var.

Issue Fixed:

Requirements:

Notes:

Needs to be backported to any release train that has multiple regions or subs in its E2E

@jpayne3506 jpayne3506 added fix Fixes something. ci Infra or tooling. release/latest Change affects latest release train needs-backport Change needs to be backported to previous release trains release/1.5 Change affects v1.5 release train labels Sep 3, 2024
@jpayne3506 jpayne3506 requested a review from a team as a code owner September 3, 2024 23:54
sheylatrudo
sheylatrudo approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@sheylatrudo sheylatrudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jpayne3506
Copy link
Contributor Author

/azp run Azure Container Networking PR

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jpayne3506 jpayne3506 added this pull request to the merge queue Sep 13, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 13, 2024
@paulyufan2 paulyufan2 added this pull request to the merge queue Sep 13, 2024
Merged via the queue into master with commit 1351a44 Sep 13, 2024
14 checks passed
@paulyufan2 paulyufan2 deleted the jpayne3506/v2-delete branch September 13, 2024 17:55
@jpayne3506 jpayne3506 mentioned this pull request Sep 27, 2024
Merged
4 tasks
jpayne3506 added a commit that referenced this pull request Nov 8, 2024
@jpayne3506
[fix] ci: cluster deletion for swiftv2 (#2986)
c87dfad 
fix: cluster deletion for swiftv2
@jpayne3506 jpayne3506 removed the needs-backport Change needs to be backported to previous release trains label Nov 12, 2024
github-merge-queue bot pushed a commit that referenced this pull request Nov 13, 2024
@jpayne3506
[backport] ci: PR pipeline yaml cleanup (#3126)
3d058ff 
* ci: Cleanup ACN PR pipeline yaml (#2861)

ci: cleanup PR yaml

* [fix] ci: cluster deletion for swiftv2 (#2986)

fix: cluster deletion for swiftv2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sheylatrudo sheylatrudo sheylatrudo approved these changes

@ZetaoZhuang ZetaoZhuang Awaiting requested review from ZetaoZhuang ZetaoZhuang is a code owner automatically assigned from Azure/azure-sdn-members

Assignees
No one assigned
Labels
ci Infra or tooling. fix Fixes something. release/latest Change affects latest release train release/1.5 Change affects v1.5 release train
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jpayne3506 @sheylatrudo @paulyufan2