Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add device plugin support to CNS #2886

Merged
merged 27 commits into from
Aug 29, 2024
Merged

feat: add device plugin support to CNS #2886

merged 27 commits into from
Aug 29, 2024

Conversation

thatmattlong
Copy link
Contributor

@thatmattlong thatmattlong commented Jul 29, 2024 •
edited by aggarwal0009
Loading

Reason for Change:
Adds a device plugin implementation for tracking vnet and IB NICs to CNS. Does not enable execution of this plugin.

Issue Fixed:

Requirements:

Notes:

@aggarwal0009 aggarwal0009 marked this pull request as ready for review August 2, 2024 01:03
@aggarwal0009 aggarwal0009 requested review from a team as code owners August 2, 2024 01:03
@aggarwal0009 aggarwal0009 requested a review from nairashu August 2, 2024 01:03
@rbtr rbtr added the cns Related to CNS. label Aug 2, 2024
@rbtr rbtr self-requested a review August 2, 2024 16:23
timraymond
timraymond reviewed Aug 2, 2024
View reviewed changes
cns/deviceplugin/plugin.go Outdated Show resolved Hide resolved
cns/deviceplugin/pluginmanager.go Outdated Show resolved Hide resolved
cns/deviceplugin/pluginmanager.go Outdated Show resolved Hide resolved
cns/deviceplugin/pluginmanager_test.go Outdated Show resolved Hide resolved
cns/deviceplugin/pluginmanager_test.go Outdated Show resolved Hide resolved
cns/deviceplugin/server.go Outdated Show resolved Hide resolved
cns/deviceplugin/socketwatcher_test.go Outdated Show resolved Hide resolved
out.txt Outdated Show resolved Hide resolved
aggarwal0009 and others added 5 commits August 2, 2024 11:24
@aggarwal0009 @timraymond
Update cns/deviceplugin/pluginmanager.go
4b95801 
Co-authored-by: Timothy J. Raymond <timraymond@users.noreply.github.com>
Signed-off-by: aggarwal0009 <127549148+aggarwal0009@users.noreply.github.com>
@aggarwal0009
remove test run output file
fdf1969
@aggarwal0009
linter fixes
079476b
@aggarwal0009
resolve readability related comments
96669dc
@aggarwal0009
Merge branch 'master' into matlong/add-device-plugin-skeleton
aed17cc
@aggarwal0009
Copy link
Contributor

/azp run Azure Container Networking PR

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

aggarwal0009
aggarwal0009 previously approved these changes Aug 6, 2024
View reviewed changes
Copy link
Contributor

@aggarwal0009 aggarwal0009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM cc @thatmattlong

cns/deviceplugin/pluginmanager_test.go Outdated Show resolved Hide resolved
@aggarwal0009 aggarwal0009 force-pushed the matlong/add-device-plugin-skeleton branch from 63cc4ea to 798e2e5 Compare August 6, 2024 21:20
aggarwal0009
aggarwal0009 previously approved these changes Aug 6, 2024
View reviewed changes
@aggarwal0009
Copy link
Contributor

/azp run Azure Container Networking PR

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@aggarwal0009
Copy link
Contributor

/azp run Azure Container Networking PR

@aggarwal0009 aggarwal0009 enabled auto-merge August 19, 2024 17:35
miguelgoms
miguelgoms previously approved these changes Aug 19, 2024
View reviewed changes
rbtr
rbtr previously approved these changes Aug 19, 2024
View reviewed changes
@aggarwal0009
Copy link
Contributor

/azp run Azure Container Networking PR

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@aggarwal0009 aggarwal0009 added this pull request to the merge queue Aug 19, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 19, 2024
@aggarwal0009 aggarwal0009 mentioned this pull request Aug 19, 2024
Merged
3 tasks
@paulyufan2 paulyufan2 added this pull request to the merge queue Aug 20, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Aug 20, 2024
@paulyufan2 paulyufan2 added this pull request to the merge queue Aug 20, 2024
@rbtr rbtr removed this pull request from the merge queue due to a manual request Aug 20, 2024
@rbtr
Copy link
Contributor

rbtr commented Aug 20, 2024

@paulyufan2 this is blocked by #2931

@aggarwal0009
Merge branch 'master' into matlong/add-device-plugin-skeleton
7aafd6b 
Signed-off-by: aggarwal0009 <127549148+aggarwal0009@users.noreply.github.com>
@aggarwal0009 aggarwal0009 dismissed stale reviews from rbtr and miguelgoms via 7aafd6b August 28, 2024 01:25
miguelgoms
miguelgoms previously approved these changes Aug 28, 2024
View reviewed changes
@aggarwal0009
Copy link
Contributor

/azp run Azure Container Networking PR

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@aggarwal0009 aggarwal0009 requested a review from rbtr August 28, 2024 16:12
@paulyufan2
Copy link
Contributor

/azp run Azure Container Networking PR

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@paulyufan2 paulyufan2 added this pull request to the merge queue Aug 29, 2024
Merged via the queue into Azure:master with commit a01f0a0 Aug 29, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kmurudi kmurudi kmurudi left review comments

@timraymond timraymond timraymond left review comments

@paulyufan2 paulyufan2 paulyufan2 approved these changes

@miguelgoms miguelgoms miguelgoms approved these changes

@aggarwal0009 aggarwal0009 aggarwal0009 left review comments

@nairashu nairashu Awaiting requested review from nairashu nairashu is a code owner automatically assigned from Azure/acn-cns-reviewers

@camrynl camrynl Awaiting requested review from camrynl

@ashvindeodhar ashvindeodhar Awaiting requested review from ashvindeodhar

@rayaisaiah rayaisaiah Awaiting requested review from rayaisaiah rayaisaiah was automatically assigned from Azure/acn-npm-reviewers

@rbtr rbtr Awaiting requested review from rbtr

Assignees
No one assigned
Labels
cns Related to CNS.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@thatmattlong @aggarwal0009 @rbtr @paulyufan2 @timraymond @kmurudi @miguelgoms