fix: Added -n option in iptables list cmd to prevent reverse dns lookup #2686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cherry pick from commit id b8f6db6
timraymond
approved these changes
Apr 15, 2024
| @@ -109,7 +109,7 @@ func RunCmd(version, params string) error { | |||
|
|
|||
| // check if iptable chain alreay exists | |||
| func ChainExists(version, tableName, chainName string) bool { | |||
| params := fmt.Sprintf("-t %s -L %s", tableName, chainName) | |||
| params := fmt.Sprintf("-t %s -nL %s", tableName, chainName) | |||
There was a problem hiding this comment.
Is it worth documenting these flags here? I know that you can look them up from the manpage, but it might be helpful to put it in front of readers' faces.
There was a problem hiding this comment.
Thanks for suggestion. This is cherry-pick PR for backport release. will add it next time in the PR created against master
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cherry pick from commit id b8f6db6
Reason for Change:
Issue Fixed:
Cherry pick this PR #2682
Requirements:
Notes: