Start two CNS servers with different handlers #2650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
825faf9 to
da26897
Compare
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
738b677 to
a6a6bad
Compare
nddq
requested changes
Mar 21, 2024
c9dd91c to
a3c58b9
Compare
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
a3c58b9 to
c4cf654
Compare
nddq
reviewed
Apr 2, 2024
tamilmani1989
requested changes
Apr 3, 2024
tamilmani1989
requested changes
Apr 4, 2024
nddq
reviewed
Apr 5, 2024
e99d190 to
f61984e
Compare
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
f9668f9 to
f61984e
Compare
tamilmani1989
requested changes
Apr 12, 2024
820a8ca to
05e2e23
Compare
3074afe to
23ca288
Compare
095df47 to
c052c37
Compare
54d6c61 to
b2d232c
Compare
Signed-off-by: Paul Yu <129891899+paulyufan2@users.noreply.github.com>
tamilmani1989
previously approved these changes
Apr 29, 2024
The startService function is a mistake that has been perpetuated through
time and needs to be removed. As a consequence of its existence, it
requires mixing concerns in all tests and stands in the way of
refactoring.
The addition of two type assertion checks caused this function to break,
because the corresponding options were not set in the Service's
configuration. This is a problem in itself--there's no reason the
options should be pulled out of a map[string]interface{}. Given this, we
can just set these two options in startService, committing sins to
offset the ones in service.(*HTTPRestService).Service.Options.
tamilmani1989
approved these changes
Apr 29, 2024
|
/azp run Azure Container Networking PR |
|
Azure Pipelines successfully started running 1 pipeline(s). |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
This PR is to start two CNS servers:
1.Localhost echo server => it will use default URL for CNI func handlers
2.HTTP legacy server => it will use private VM's ip or IP that customer provides for DNC/CNS func handlers
Issue Fixed:
Requirements:
Notes: