feat: build standalone azure-ipam installer image #2339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6b26e21 to
b5b58d1
Compare
2e58279 to
703a0ad
Compare
pjohnst5
reviewed
Oct 31, 2023
pjohnst5
requested changes
Oct 31, 2023
vipul-21
reviewed
Oct 31, 2023
vipul-21
previously approved these changes
Oct 31, 2023
703a0ad to
45f3b5f
Compare
45f3b5f to
8bde06f
Compare
8bde06f to
2b60652
Compare
Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
2b60652 to
71efd69
Compare
camrynl
approved these changes
Nov 1, 2023
rbtr
added a commit
that referenced
this pull request
Jul 22, 2024
feat: build azure-ipam installer image Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
rbtr
added a commit
that referenced
this pull request
Sep 26, 2024
feat: build azure-ipam installer image Signed-off-by: Evan Baker <rbtr@users.noreply.github.com>
rbtr
added a commit
that referenced
this pull request
Sep 27, 2024
rbtr
added a commit
that referenced
this pull request
Sep 27, 2024
rbtr
added a commit
that referenced
this pull request
Sep 27, 2024
rbtr
added a commit
that referenced
this pull request
Sep 27, 2024
rbtr
added a commit
that referenced
this pull request
Sep 27, 2024
rbtr
added a commit
that referenced
this pull request
Sep 27, 2024
rbtr
added a commit
that referenced
this pull request
Sep 27, 2024
rbtr
added a commit
that referenced
this pull request
Sep 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
Previously we have released the CNI installer image as a separately versioned component from the CNI releases themselves. This has created a bit of versioning hell, as we struggle to maintain multiple release trains of the CNI (and thus CNI installer) when the CNI and installer version are not correlated.
This change flips the CNI installer image builder architecture. Previously, dropgz pulled in the released azure-ipam binaries as dependencies and produced a "dropgz-vX" omnibus image which also contained uncorrelated CNI versions.
Here, we migrate instead to an azure-ipam Dockerfile which imports dropgz as the dependency and is built in lockstep with (at least) azure-ipam builds, and versioned the same as them. Instead of deploying a "dropgz:v0.0.4" with unknown (at least, non-obvious) CNI payload versions, we produce a "azipam-installer:v0.0.5" during the CNI release process with no ambiguity.
Issue Fixed:
Part of #2333
Requirements:
Notes: