fix: skip setting SdnRemoteArpMacAddress when hns is not enabled #2315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9323adc to
6b5cc8d
Compare
6b5cc8d to
d85d77d
Compare
ashvindeodhar
requested changes
Oct 24, 2023
platform/os_windows.go
Outdated
| @@ -68,6 +68,10 @@ const ( | |||
| SetSdnRemoteArpMacAddressCommand = "Set-ItemProperty " + | |||
| "-Path HKLM:\\SYSTEM\\CurrentControlSet\\Services\\hns\\State -Name SDNRemoteArpMacAddress -Value \"12-34-56-78-9a-bc\"" | |||
|
|
|||
| // Command to check if system have hns path or not | |||
| CheckIfHNSPathExistsCommand = "Test-Path " + | |||
There was a problem hiding this comment.
Please add HNSState in the var for correctness - CheckIfHNSStatePathExistsCommand
platform/os_windows.go
Outdated
| func SetSdnRemoteArpMacAddress(execClient ExecClient) error { | ||
| exists, err := execClient.ExecutePowershellCommand(CheckIfHNSPathExistsCommand) | ||
| if err != nil { | ||
| errMsg := fmt.Sprintf("Failed to check the existent of hns path due to error %s", err.Error()) |
platform/os_windows_test.go
Outdated
| mockExecClient := NewMockExecClient(false) | ||
| // testing skip setting SdnRemoteArpMacAddress when hns not enabled | ||
| mockExecClient.SetPowershellCommandResponder(func(_ string) (string, error) { | ||
| return "false", nil |
There was a problem hiding this comment.
nit: return False and True instead of false / true to reflect the actual values returned ( which are case sensitive which will also test the equalFold )
Signed-off-by: ZetaoZhuang <106119232+ZetaoZhuang@users.noreply.github.com>
Signed-off-by: ZetaoZhuang <106119232+ZetaoZhuang@users.noreply.github.com>
ashvindeodhar
approved these changes
Oct 27, 2023
Signed-off-by: ZetaoZhuang <106119232+ZetaoZhuang@users.noreply.github.com>
Signed-off-by: ZetaoZhuang <106119232+ZetaoZhuang@users.noreply.github.com>
msvik
reviewed
Oct 30, 2023
Signed-off-by: ZetaoZhuang <106119232+ZetaoZhuang@users.noreply.github.com>
Signed-off-by: ZetaoZhuang <106119232+ZetaoZhuang@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for Change:
fix: skip setting SdnRemoteArpMacAddress when hns is not enabled
Issue Fixed:
Requirements:
Notes: