Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: add Cilium OS/Proc coverage to CNI Load Test pipeline #2296

Merged
merged 1 commit into from
Nov 1, 2023
Merged

ci: add Cilium OS/Proc coverage to CNI Load Test pipeline #2296

merged 1 commit into from
Nov 1, 2023

Conversation

jpayne3506
Copy link
Contributor

Reason for Change:

Increases coverage of cilium OS/Processor configurations on overlay clusters.

Issue Fixed:

Requirements:

Notes:

@jpayne3506 jpayne3506 added the ci Infra or tooling. label Oct 17, 2023
@jpayne3506 jpayne3506 self-assigned this Oct 17, 2023
@jpayne3506 jpayne3506 requested a review from a team as a code owner October 17, 2023 16:13
@jpayne3506 jpayne3506 force-pushed the jpayne3506/cilliumosproc branch from 2807eec to c7342c0 Compare October 19, 2023 16:39
rbtr
rbtr approved these changes Oct 31, 2023
View reviewed changes
Copy link
Contributor

@rbtr rbtr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will we be expanding the matrix on azure-vnet scenarios also?

@jpayne3506 jpayne3506 force-pushed the jpayne3506/cilliumosproc branch from c7342c0 to e2295d8 Compare October 31, 2023 22:00
@jpayne3506 jpayne3506 enabled auto-merge (squash) October 31, 2023 22:00
@jpayne3506
Copy link
Contributor Author

will we be expanding the matrix on azure-vnet scenarios also?

Not that I am aware of. This expansion, OS/Processor, is focused on overlay.

@jpayne3506 jpayne3506 merged commit 5931f8f into master Nov 1, 2023
@jpayne3506 jpayne3506 deleted the jpayne3506/cilliumosproc branch November 1, 2023 00:18
@rbtr
Copy link
Contributor

rbtr commented Nov 1, 2023

will we be expanding the matrix on azure-vnet scenarios also?

Not that I am aware of. This expansion, OS/Processor, is focused on overlay.

azure-vnet supports overlay

@jpayne3506
Copy link
Contributor Author

will we be expanding the matrix on azure-vnet scenarios also?

Not that I am aware of. This expansion, OS/Processor, is focused on overlay.

azure-vnet supports overlay

In that case, we are only doing expansion with overlay. Thought you were referring to azure-vnet-ipam.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rbtr rbtr rbtr approved these changes

@vipul-21 vipul-21 vipul-21 approved these changes

@camrynl camrynl Awaiting requested review from camrynl

@jshr-w jshr-w Awaiting requested review from jshr-w

Assignees

@jpayne3506 jpayne3506

Labels
ci Infra or tooling.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jpayne3506 @rbtr @vipul-21