[Monitor] Fix activity-log list issues.
#7525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adewaleo
reviewed
Oct 11, 2018
| the start time will be calculated by subtracting the offset. If --start-time and --end-time are | ||
| provided, then --offset will be ignored. | ||
| examples: | ||
| - name: List all events from July 1st, looking forward one week. |
There was a problem hiding this comment.
Would it be possible to add an example using the --caller and --namespace parameters?
There was a problem hiding this comment.
Yes, but it doesn't contribute to understanding and just clutters the help screen.
| c.argument('correlation_id') | ||
| c.argument('caller') | ||
| c.argument('resource_group') | ||
| c.argument('resource_group', resource_group_name_type) |
There was a problem hiding this comment.
Yes, because the global alias is for resource_group_name.
There was a problem hiding this comment.
I was wondering if this extra argument registration was necessary given the CLI would automatically surface the resource_group parameter.
Thanks for clarifying.
| if match_len != tuple([0, len(value)]): | ||
| raise ValueError | ||
| # simply return value if a valid ISO8601 string is supplied | ||
| if match.regs[1] != tuple([-1, -1]) and match.regs[5] != tuple([-1, -1]): |
There was a problem hiding this comment.
FYI: It seems like match.regs is undocumented and might be deprecated in the future.
adewaleo
approved these changes
Oct 11, 2018
jaysterp
added a commit
to AzureCR/azure-cli
that referenced
this pull request
Oct 25, 2018
* Progress (Azure#7558) * update knack 0.4.4 (Azure#7567) * Update CODEOWNERS (Azure#7571) * Add table for exit codes (Azure#7572) * Updated adls version to 0.0.34 (Azure#7570) * Updated adls version to 0.0.33 * Updated version * Update version * Downgrade to 0.0.32 due to test failures * Updated test recordings with new version and updated to version 0.0.34 again * Updated History.rst * Merge CLI 2.0.48 hotfix to dev and bump versions (Azure#7590) * Homebrew hotfix. * CI issue? * make scrubbed over value valid base64 (Azure#7592) * Graph: support add/remove/list owners on app, sp, and group (Azure#7578) * Container Instance: Updating VNET workflow (Azure#7517) * Adding vnet-resource-group * fixing wording for more clear content * Removing vnet-resource-group * allow passing in vnet name or id * updating container module version * adding wording change for the LRP in container warning. * reverting version back to current version * Adding private option for --ip-address * updating tests for new parameters * updating tests recordings * Removing the ability to create VNET by passing the resource ID * adding --vnet-name back for backwards compatability * Fixing based on feedback * Bumping the version for CItests * updating container instance sdk version * changing casing and removing existance check * fixing no image error validation * Fix CI. Remove autopep8 dependency (Azure#7597) * Update tools setup. * Remove autopep8 * Iot Central Added Display Name and Template Parameters for App Create (Azure#7518) * [Storage] allow deletion of containers with immutability policy after service bug fix (Azure#7569) * delete container to custom command * finished up commands * added test * history and pep8 * linter, static * new recording after scrubbing fix * comment typo * vmss: avoid producing useless stroage accounts with unmanaegd scaleset (Azure#7601) * [Monitor] Fix `activity-log list` issues. (Azure#7525) * Fix Azure#5608. Fix Azure#4885. * Update Metric command. * Container Instance: Role Assignment for System Assigned MSI (Azure#7577) * adding deployment based for resources * changing to sdk calls for role assignment * Fixing naming problem causing authorization client to fail * Fixing formatting errors * fixing differnt return statemnet errors * adding tests for the --scope parameter * fixing conflicts in recordings * fixing conflicts and rerecording tests * removing whitespace * making non predictble test live only * Fixing blank lines * allow role assignment for --no-wait aswell * removed unused imports * CLI now prints extension messages. E.g. This extension is in preview. The behavior of this command has been altered by the following extension: storage-preview (Azure#7606) * Removing Warnings for Cloudshell Proxy (Azure#7605) * removing warnings for cloudshell proxy * updating code owners for the container modules * Updating how env var is accessed * fixing formatting error in string message * removing unused import * Bump versions for next CLI release (Azure#7610) * AAD Graph: support grant/list app permissions(Azure#7611) Contributed by: @shanepeckham Payload details: https://blogs.msdn.microsoft.com/arsen/2017/07/30/azure-ad-how-to-create-oauth2permissiongrant-using-graph-api-grant-permissions-and-consent-for-application/ * Fixes Azure#7596. (Azure#7620) * Retry webbrowser.open() after a TypeError (Azure#7542) * [Monitor] Metric alerts - allow special characters in metric name (Azure#7623) * Fixes Azure#7598. * Add test. * Closes Azure#7545. * moved interactive events to core (Azure#7632) * Fixed bug where --no-wait option causes vm resize to crash. (Azure#7627) * Fixed bug where --no-wait option causes vm resize to crash. * Bump up VM version number * Update rdbms help examples text from Gen4 to Gen5 (Azure#7642) * Update rdbms help examples text from Gen4 to Gen5 * Fix version * Fix public-ip create. (Azure#7638) * image create now accepts a storage-sku. (Azure#7614) * image create now accepts a storage-sku. Unused when source is a VM due to service side issue. Also updated help text and made some changes to some model imports. * Updated storage-sku help parameter * Fixed bug introduced by using get_models. For profiles that don't have StorageAccountTypes defined define the possible storage-sku values. * History changes. * Bumped up VM version number. removed extra newline in History.rst * Added test coverage for --storage-sku * Comment explaining else statement in vm/_params.py * Modified test_vm_managed_disk * Addressed pep8 warnings. * ACR: Add Pull Request Event to Task Source Trigger (Azure#7526) * initial work on the PR trigger * task create and update with PR trigger * use one flag to enable commit and pr trigger events * nit fixes * Two event flags and only support one source trigger per task * PR fixes * allow empty event list when disabling all trigger events * format fix * do not clear event list in update, instead status disabled * update task table * nit fix * bump cli event version * nit fixes * update ACR sdk version * version fix * update appservice version * pylint fixes * pylint fixes * nit * pylint fix * respond to PR comments * change from null to empty check * ad: clarify the confusion between displayName and service principal name (Azure#7651) * [setup]: windows installer improvement (Azure#7633) * revert to desktop python * change before do model file concat * add trimmer * revert an unrelated change * incorporate model file trimmer * revert a few unnecessary change * lint fix * remove an irrelevant command file * backup python to storage accounts * remove irrelevant comment * simplify * Closes Azure#7536 (Azure#7626) * pin flake8 to 3.5.0 (Azure#7663) * pin flake8 to 3.5.0 * wrong version * setup: add back the workaround of pinning pycparser==2.18 (Azure#7662) * Fixed bug with update --remove --ids (Azure#7643) * Fixed bug where if update --remove is called with --ids, the correct params aren't passed in subsequent iterations of the update command. * Fixed Pep8 issues * Fixed bug by changing generic update logic instead of copying CLI params. * Move extension logic into core (Azure#7653) * moved previous 'extensions' event handling logic * moved all extension management utility to core * fix ref static checking fix test import * core package * fix reference * renamed to register_global_transforms * Update to latest Advisor SDK (Azure#7576) * Updates for GA release. * Addressing PR feedback: - Removed 'recommendation generate' command and added a '--refresh' option to 'recommendation list' instead. - Renamed 'configuration get' to 'configuration list'. - Renamed 'configuration set' to 'configuration update'. - Test recording updates. * Update history with details of the changes. * Adding generic update and show command. * Addressing review feedback. * Update SDK package version. * Addressing review feedback. * Fix indentation errors. * Add support for ids. * Updates for GA release. * Addressing PR feedback: - Removed 'recommendation generate' command and added a '--refresh' option to 'recommendation list' instead. - Renamed 'configuration get' to 'configuration list'. - Renamed 'configuration set' to 'configuration update'. - Test recording updates. * Update history with details of the changes. * Adding generic update and show command. * Addressing review feedback. * Update SDK package version. * Addressing review feedback. * Fix indentation errors. * Add support for ids. * Fix test failures. * Update to latest SDK version * Update history * Reference new package version * Fixed non-working example for mysql db create (Azure#7557) * Update _help.py Fixed non-working example with guidance from https://docs.microsoft.com/en-us/azure/mysql/quickstart-create-mysql-server-database-using-azure-cli * Update HISTORY.rst * Update setup.py * Fix placeholder * Fix Azure#7659 (Azure#7668)
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5608. Fix #4885.
Closes #6196. Closes #6198.
--offsetparameter to more easily create time queries.--namespaceas alias for deprecated option--resource-provider.--filtersbecause no values other than those with strongly-typed options are supported by the service.cc/ @JasonRShaver
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR has modified HISTORY.rst describing any customer-facing, functional changes. Note that this does not include changes only to help content. (see Modifying change log).
I adhere to the Command Guidelines.