{CI} reassign issue owner #29260
Merged
{CI} reassign issue owner #29260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
|
Hi @Pan-Qi, |
️✔️AzureCLI-BreakingChangeTest
|
|
Please fix CI issues |
bebound
reviewed
Jul 16, 2024
| pattern: '[Aa]z \b(group|resource|provider|feature|tag|policy|lock|managedapp|resourcemanagement)\b' | ||
| isRegex: True | ||
| - titleContains: | ||
| pattern: '[Aa]z account (clear|get-access-token|list|list-locations|set|show)\b' |
There was a problem hiding this comment.
az account will assign to Jiashuo, is this expected?
There was a problem hiding this comment.
Yes, az account normally comes with a following flag(command) like clear or list. If it's not specified, we treat it as a new command and temporarily assign to Jiashuo.
bebound
reviewed
Jul 16, 2024
| - payloadType: Issues | ||
| - or: | ||
| - titleContains: | ||
| pattern: '[Aa]z account(?!(\s+(clear|get-access-token|list|list-locations|set|show))\b)\s*\b' |
There was a problem hiding this comment.
What's the purpose of \s*\b at the end of regex?
There was a problem hiding this comment.
The command can contain one or more tailing whitespace(\s*) and \b is a word boundary assertion, it helps to match whole words rather than substrings within words.
e.g.
Matched: Az account details
Matched: Az account
Not matched: Az account set
Not matched: Az accountlist
Not matched: Az accountother
Matched: az account other
There was a problem hiding this comment.
I see. Then this regex can be simplified to [Aa]z account\b(?!\s+(clear|get-access-token|list|list-locations|set|show)\b).
There was a problem hiding this comment.
yeah, it looks good, if az account ** should be matched, we don't need to worry about tailings words
bebound
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GH issues related to az account were all assigned to XingZhou.
Now we want to assign commands within
Commandsto XingZhou, but commands withinSubgroupto Jiashuo.If there is a new command not one of those 8 existing commands, temporarily assign to Jiashuo.
Change:
[Aa]z account (clear|get-access-token|list|list-locations|set|show)\bwill matchAz accountoraz accountfollowed with any command underCommandsgroup which is assigned toXingZhou[Aa]z account(?!(\s+(clear|get-access-token|list|list-locations|set|show))\b)\s*\bwill matchAz accountoraz accountorAz accountoraz accountfollowed with any command not underCommandsgroup which is assign toJiashuo LiThis PR also add
.gitignoreto ignore files undercmd_coveragefolder created byazdev cmdcovcommand.Related command
Description
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.