Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AKS] az aks create/update: Add new parameter --node-os-upgrade-channel to specify which OS on your nodes is updated #27167

Merged
merged 2 commits into from
Aug 17, 2023

Conversation

paulgmiller
Copy link
Member

@paulgmiller paulgmiller commented Aug 14, 2023

…com/Azure/azure-cli-extensions/pull/5788/files

Related command
az aks create|update

Description
This allows the setting of node os upgrade channel in create and update of aks clusters.
Public docs are here. https://learn.microsoft.com/en-us/azure/aks/auto-upgrade-node-image

It is GAing this preview extension: Azure/azure-cli-extensions#5788

This became available in the 06-01 api.

Testing Guide
Same tests as extension create and update with nodeos upgrade channel. Make sure its preserved. Combine with upgrade chennel

History Notes
[AKS] az aks create/update: Add new parameter --node-os-upgrade-channel to specify which OS on your nodes is updated


This checklist is used to make sure that common guidelines for a pull request are followed.

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Aug 14, 2023

️✔️AzureCLI-FullTest
️✔️acr
️✔️2020-09-01-hybrid
️✔️3.10
️✔️3.9
️✔️latest
️✔️3.10
️✔️3.9
️✔️acs
️✔️2020-09-01-hybrid
️✔️3.10
️✔️3.9
️✔️latest
️✔️3.10
️✔️3.9
️✔️advisor
️✔️latest
️✔️3.10
️✔️3.9
️✔️ams
️✔️latest
️✔️3.10
️✔️3.9
️✔️apim
️✔️latest
️✔️3.10
️✔️3.9
️✔️appconfig
️✔️latest
️✔️3.10
️✔️3.9
️✔️appservice
️✔️latest
️✔️3.10
️✔️3.9
️✔️aro
️✔️latest
️✔️3.10
️✔️3.9
️✔️backup
️✔️latest
️✔️3.10
️✔️3.9
️✔️batch
️✔️latest
️✔️3.10
️✔️3.9
️✔️batchai
️✔️latest
️✔️3.10
️✔️3.9
️✔️billing
️✔️latest
️✔️3.10
️✔️3.9
️✔️botservice
️✔️latest
️✔️3.10
️✔️3.9
️✔️cdn
️✔️latest
️✔️3.10
️✔️3.9
️✔️cloud
️✔️latest
️✔️3.10
️✔️3.9
️✔️cognitiveservices
️✔️latest
️✔️3.10
️✔️3.9
️✔️config
️✔️latest
️✔️3.10
️✔️3.9
️✔️configure
️✔️latest
️✔️3.10
️✔️3.9
️✔️consumption
️✔️latest
️✔️3.10
️✔️3.9
️✔️container
️✔️latest
️✔️3.10
️✔️3.9
️✔️core
️✔️2018-03-01-hybrid
️✔️3.10
️✔️3.9
️✔️2019-03-01-hybrid
️✔️3.10
️✔️3.9
️✔️2020-09-01-hybrid
️✔️3.10
️✔️3.9
️✔️latest
️✔️3.10
️✔️3.9
️✔️cosmosdb
️✔️latest
️✔️3.10
️✔️3.9
️✔️databoxedge
️✔️2019-03-01-hybrid
️✔️3.10
️✔️3.9
️✔️2020-09-01-hybrid
️✔️3.10
️✔️3.9
️✔️latest
️✔️3.10
️✔️3.9
️✔️dla
️✔️latest
️✔️3.10
️✔️3.9
️✔️dls
️✔️latest
️✔️3.10
️✔️3.9
️✔️dms
️✔️latest
️✔️3.10
️✔️3.9
️✔️eventgrid
️✔️latest
️✔️3.10
️✔️3.9
️✔️eventhubs
️✔️latest
️✔️3.10
️✔️3.9
️✔️feedback
️✔️latest
️✔️3.10
️✔️3.9
️✔️find
️✔️latest
️✔️3.10
️✔️3.9
️✔️hdinsight
️✔️latest
️✔️3.10
️✔️3.9
️✔️identity
️✔️latest
️✔️3.10
️✔️3.9
️✔️iot
️✔️2019-03-01-hybrid
️✔️3.10
️✔️3.9
️✔️2020-09-01-hybrid
️✔️3.10
️✔️3.9
️✔️latest
️✔️3.10
️✔️3.9
️✔️keyvault
️✔️2018-03-01-hybrid
️✔️3.10
️✔️3.9
️✔️2020-09-01-hybrid
️✔️3.10
️✔️3.9
️✔️latest
️✔️3.10
️✔️3.9
️✔️kusto
️✔️latest
️✔️3.10
️✔️3.9
️✔️lab
️✔️latest
️✔️3.10
️✔️3.9
️✔️managedservices
️✔️latest
️✔️3.10
️✔️3.9
️✔️maps
️✔️latest
️✔️3.10
️✔️3.9
️✔️marketplaceordering
️✔️latest
️✔️3.10
️✔️3.9
️✔️monitor
️✔️latest
️✔️3.10
️✔️3.9
️✔️mysql
️✔️latest
️✔️3.10
️✔️3.9
️✔️netappfiles
️✔️latest
️✔️3.10
️✔️3.9
️✔️network
️✔️2018-03-01-hybrid
️✔️3.10
️✔️3.9
️✔️latest
️✔️3.10
️✔️3.9
️✔️policyinsights
️✔️latest
️✔️3.10
️✔️3.9
️✔️privatedns
️✔️latest
️✔️3.10
️✔️3.9
️✔️profile
️✔️latest
️✔️3.10
️✔️3.9
️✔️rdbms
️✔️latest
️✔️3.10
️✔️3.9
️✔️redis
️✔️latest
️✔️3.10
️✔️3.9
️✔️relay
️✔️latest
️✔️3.10
️✔️3.9
️✔️resource
️✔️2018-03-01-hybrid
️✔️3.10
️✔️3.9
️✔️2019-03-01-hybrid
️✔️3.10
️✔️3.9
️✔️latest
️✔️3.10
️✔️3.9
️✔️role
️✔️latest
️✔️3.10
️✔️3.9
️✔️search
️✔️latest
️✔️3.10
️✔️3.9
️✔️security
️✔️latest
️✔️3.10
️✔️3.9
️✔️servicebus
️✔️latest
️✔️3.10
️✔️3.9
️✔️serviceconnector
️✔️latest
️✔️3.10
️✔️3.9
️✔️servicefabric
️✔️latest
️✔️3.10
️✔️3.9
️✔️signalr
️✔️latest
️✔️3.10
️✔️3.9
️✔️sql
️✔️latest
️✔️3.10
️✔️3.9
️✔️sqlvm
️✔️latest
️✔️3.10
️✔️3.9
️✔️storage
️✔️2018-03-01-hybrid
️✔️3.10
️✔️3.9
️✔️2019-03-01-hybrid
️✔️3.10
️✔️3.9
️✔️2020-09-01-hybrid
️✔️3.10
️✔️3.9
️✔️latest
️✔️3.10
️✔️3.9
️✔️synapse
️✔️latest
️✔️3.10
️✔️3.9
️✔️telemetry
️✔️2018-03-01-hybrid
️✔️3.10
️✔️3.9
️✔️2019-03-01-hybrid
️✔️3.10
️✔️3.9
️✔️2020-09-01-hybrid
️✔️3.10
️✔️3.9
️✔️latest
️✔️3.10
️✔️3.9
️✔️util
️✔️latest
️✔️3.10
️✔️3.9
️✔️vm
️✔️2018-03-01-hybrid
️✔️3.10
️✔️3.9
️✔️2019-03-01-hybrid
️✔️3.10
️✔️3.9
️✔️2020-09-01-hybrid
️✔️3.10
️✔️3.9
️✔️latest
️✔️3.10
️✔️3.9

@azure-client-tools-bot-prd
Copy link

azure-client-tools-bot-prd bot commented Aug 14, 2023

⚠️AzureCLI-BreakingChangeTest
⚠️acs
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd aks create cmd aks create added parameter node_os_upgrade_channel
⚠️ 1006 - ParaAdd aks update cmd aks update added parameter node_os_upgrade_channel

@yonzhan
Copy link
Collaborator

yonzhan commented Aug 14, 2023

Thank you for your contribution! We will review the pull request and get back to you soon.

@paulgmiller paulgmiller marked this pull request as ready for review August 15, 2023 04:28
@paulgmiller paulgmiller changed the title try and bring in node os upgrade channel from preview https://github.… [aks] az aks create|update: allow use of --node-os-upgade channel Aug 15, 2023
@paulgmiller
Copy link
Member Author

@wangzelin007 and @FumingZhang would you mind looking at this sicne you approved Azure/azure-cli-extensions#5788 it should be a mirror of that.

Also we can remove code from preview extension after this is live.

Since this gives customers a way to disable Unattended Upgrades (which caused a sev 1 across several regions on saturday we might actually ask for an expidtited release of this)

@paulgmiller paulgmiller changed the title [aks] az aks create|update: allow use of --node-os-upgade channel [aks] az aks create|update: allow use of --node-os-upgade channel Aug 15, 2023
@paulgmiller paulgmiller changed the title [aks] az aks create|update: allow use of --node-os-upgade channel [aks] az aks create|update: Allow use of --node-os-uprgade channel Aug 15, 2023
Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@paulgmiller paulgmiller force-pushed the pmiller/nodeosupgradechannel branch from 2a83a2e to 096d578 Compare August 15, 2023 05:57
@zhoxing-ms zhoxing-ms changed the title [aks] az aks create|update: Allow use of --node-os-uprgade channel [aks] az aks create/update: Allow use of --node-os-uprgade channel Aug 15, 2023
@zhoxing-ms zhoxing-ms changed the title [aks] az aks create/update: Allow use of --node-os-uprgade channel [AKS] az aks create/update: Allow use of --node-os-uprgade channel Aug 15, 2023
@zhoxing-ms zhoxing-ms changed the title [AKS] az aks create/update: Allow use of --node-os-uprgade channel [AKS] az aks create/update: Add new parameter --node-os-upgrade-channel to specify which OS on your nodes is updated Aug 15, 2023
…com/Azure/azure-cli-extensions/pull/5788/files

update linter

revert history

try and clean up whitespace

bad whitespace

security pathc is not ga yet
@paulgmiller paulgmiller force-pushed the pmiller/nodeosupgradechannel branch from 096d578 to dedc457 Compare August 15, 2023 18:32
@paulgmiller paulgmiller force-pushed the pmiller/nodeosupgradechannel branch from dedc457 to 0637eb4 Compare August 16, 2023 15:47
@paulgmiller
Copy link
Member Author

@zhoxing-ms anythign else you need here?

@zhoxing-ms zhoxing-ms merged commit c963779 into Azure:dev Aug 17, 2023
paulgmiller added a commit to paulgmiller/azure-cli that referenced this pull request Aug 29, 2023
…annel` to specify which OS on your nodes is updated (Azure#27167)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants