-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AKS] az aks create/update
: Add new parameter --node-os-upgrade-channel
to specify which OS on your nodes is updated
#27167
[AKS] az aks create/update
: Add new parameter --node-os-upgrade-channel
to specify which OS on your nodes is updated
#27167
Conversation
️✔️AzureCLI-FullTest
|
|
rule | cmd_name | rule_message | suggest_message |
---|---|---|---|
aks create | cmd aks create added parameter node_os_upgrade_channel |
||
aks update | cmd aks update added parameter node_os_upgrade_channel |
Thank you for your contribution! We will review the pull request and get back to you soon. |
@wangzelin007 and @FumingZhang would you mind looking at this sicne you approved Azure/azure-cli-extensions#5788 it should be a mirror of that. Also we can remove code from preview extension after this is live. Since this gives customers a way to disable Unattended Upgrades (which caused a sev 1 across several regions on saturday we might actually ask for an expidtited release of this) |
az aks create|update
: allow use of --node-os-upgade channel
az aks create|update
: allow use of --node-os-upgade channelaz aks create|update
: Allow use of --node-os-uprgade
channel
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
2a83a2e
to
096d578
Compare
az aks create|update
: Allow use of --node-os-uprgade
channelaz aks create/update
: Allow use of --node-os-uprgade
channel
az aks create/update
: Allow use of --node-os-uprgade
channelaz aks create/update
: Allow use of --node-os-uprgade
channel
az aks create/update
: Allow use of --node-os-uprgade
channelaz aks create/update
: Add new parameter --node-os-upgrade-channel
to specify which OS on your nodes is updated
…com/Azure/azure-cli-extensions/pull/5788/files update linter revert history try and clean up whitespace bad whitespace security pathc is not ga yet
096d578
to
dedc457
Compare
dedc457
to
0637eb4
Compare
@zhoxing-ms anythign else you need here? |
…annel` to specify which OS on your nodes is updated (Azure#27167)
…com/Azure/azure-cli-extensions/pull/5788/files
Related command
az aks create|update
Description
This allows the setting of node os upgrade channel in create and update of aks clusters.
Public docs are here. https://learn.microsoft.com/en-us/azure/aks/auto-upgrade-node-image
It is GAing this preview extension: Azure/azure-cli-extensions#5788
This became available in the 06-01 api.
Testing Guide
Same tests as extension create and update with nodeos upgrade channel. Make sure its preserved. Combine with upgrade chennel
History Notes
[AKS]
az aks create/update
: Add new parameter--node-os-upgrade-channel
to specify which OS on your nodes is updatedThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.