{Packaging} Bump requests to 2.31.0 and urllib3 to 1.26.16 #26571
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
|
Bump requests to fix |
yonzhan
previously approved these changes
May 31, 2023
jiasli
previously approved these changes
May 31, 2023
jiasli
reviewed
May 31, 2023
| @@ -127,7 +127,7 @@ PyNaCl==1.5.0 | |||
| pyOpenSSL==22.1.0 | |||
| python-dateutil==2.8.0 | |||
| requests-oauthlib==1.2.0 | |||
| requests[socks]==2.26.0 | |||
| requests[socks]==2.31.0 | |||
There was a problem hiding this comment.
Here is the fix commit: psf/requests@74ea7cf
It looks like a logic error in requests.
jiasli
approved these changes
May 31, 2023
This was referenced Jun 19, 2023
avgale
pushed a commit
to avgale/azure-cli
that referenced
this pull request
Aug 24, 2023
* Init * Bump urllib3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Bump requests to fix CVE-2023-32681
Also bump urllib3 to latest version
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.