{Service Connector} Some improvements on command experience #22822
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houk-ms
commented
Jun 10, 2022
Comment on lines
+1086
to
+1094
| RESOURCE.SignalR: [ | ||
| CLIENT_TYPE.Dotnet, | ||
| CLIENT_TYPE.Blank | ||
| ], | ||
| RESOURCE.WebPubSub: [ | ||
| CLIENT_TYPE.Java, | ||
| CLIENT_TYPE.Dotnet, | ||
| CLIENT_TYPE.Blank | ||
| ], |
There was a problem hiding this comment.
@xfz11 please confirm the clientType here
There was a problem hiding this comment.
WebPubSub also includes Python, Nodejs
There was a problem hiding this comment.
Python, Nodejs are alreay added for webapp+webpubsub
this is for Spring-Cloud, spring-cloud itself doesn't support Python NodeJs, right
|
Service Connector |
xfz11
approved these changes
Jun 10, 2022
kairu-ms
approved these changes
Jun 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related command
az spring connection list-support-typesaz {source} connection validateDescription
This PR fixes the following issues
az spring connection list-support-typesdoesn't workThe PR also provides the following improvements
--newparameteraz {source} connection validateoutput improvement, only show useful infoTesting Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.