Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{AKS} Refactor aks nodepool add - part 10 #22027

Merged
merged 7 commits into from
Apr 12, 2022

Conversation

FumingZhang
Copy link
Member

Description

  • Bug fix for decorator pattern
  • Remove deprecated code

Unit Test Coverage

"covered_lines": 475,
"num_statements": 479,
"percent_covered": 99.16492693110648,
"percent_covered_display": "99",
"missing_lines": 4,
"excluded_lines": 0

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change
[Component Name 2] az command b: Add some customer-facing feature


This checklist is used to make sure that common guidelines for a pull request are followed.

@ghost ghost requested review from zhoxing-ms and wangzelin007 April 12, 2022 05:40
@ghost ghost assigned zhoxing-ms Apr 12, 2022
@ghost ghost added this to the Apr 2022 (2022-04-26) milestone Apr 12, 2022
@ghost ghost added the Auto-Assign Auto assign by bot label Apr 12, 2022
@ghost ghost requested a review from yonzhan April 12, 2022 05:40
@ghost ghost added the AKS az aks/acs/openshift label Apr 12, 2022
@FumingZhang FumingZhang marked this pull request as ready for review April 12, 2022 07:51
@zhoxing-ms zhoxing-ms merged commit 931fa3a into Azure:dev Apr 12, 2022
@FumingZhang FumingZhang deleted the fuming/aks-np-add-p10 branch May 5, 2022 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AKS az aks/acs/openshift Auto-Assign Auto assign by bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants