Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{CI} Pin azure-mgmt-loganalytics to 13.0.0b2 #21988

Merged
merged 2 commits into from
Apr 8, 2022
Merged

Conversation

jiasli
Copy link
Member

@jiasli jiasli commented Apr 8, 2022

Description

azure-mgmt-loganalytics released 13.0.0b3 today and it breaks our CI pipeline.

https://dev.azure.com/azure-sdk/public/_build/results?buildId=1491552&view=logs&jobId=a49103b8-20d1-5a8c-534b-bda9ab69fa51&j=a49103b8-20d1-5a8c-534b-bda9ab69fa51&t=f07883fb-9b2e-5ef1-366a-e8e57e798ca5

2022-04-08T04:17:15.0187530Z ======================================================================
2022-04-08T04:17:15.0188476Z ERROR: test_ref_doc_log-analytics-solution (__main__.IndexRefDocs)
2022-04-08T04:17:15.0189463Z ----------------------------------------------------------------------
2022-04-08T04:17:15.0189976Z Traceback (most recent call last):
2022-04-08T04:17:15.0190453Z   File "/home/vsts/work/1/s/./scripts/ci/index_ref_doc.py", line 65, in test
2022-04-08T04:17:15.0190908Z     raise e
2022-04-08T04:17:15.0191334Z   File "/home/vsts/work/1/s/./scripts/ci/index_ref_doc.py", line 62, in test
2022-04-08T04:17:15.0191813Z     check_call(script_args)
2022-04-08T04:17:15.0192329Z   File "/opt/hostedtoolcache/Python/3.10.4/x64/lib/python3.10/subprocess.py", line 369, in check_call
2022-04-08T04:17:15.0192860Z     raise CalledProcessError(retcode, cmd)
2022-04-08T04:17:15.0194187Z subprocess.CalledProcessError: Command '['/opt/hostedtoolcache/Python/3.10.4/x64/bin/python', '/home/vsts/work/1/s/scripts/refdoc/generate.py', '--extension-file', '/tmp/tmp_9jktsa8/log_analytics_solution-0.1.1-py2.py3-none-any.whl', '--output-dir', '/tmp/tmpwgn9gozo/log-analytics-solution']' returned non-zero exit status 1.

https://dev.azure.com/azure-sdk/public/_build/results?buildId=1491559&view=logs&jobId=7621d84f-e7df-5fb0-9a4f-5fbdcb3421ee&j=7621d84f-e7df-5fb0-9a4f-5fbdcb3421ee&t=bbcd1db7-629e-5645-8ed8-a18b90e0a11a

2022-04-08T04:22:50.2175954Z ERROR: az_command_data_logger: cannot import name 'LogAnalyticsManagementClient' from 'azure.mgmt.loganalytics' (/opt/hostedtoolcache/Python/3.10.4/x64/lib/python3.10/site-packages/azure/mgmt/loganalytics/__init__.py)
2022-04-08T04:22:50.2176706Z Traceback (most recent call last):
2022-04-08T04:22:50.2177469Z   File "/opt/hostedtoolcache/Python/3.10.4/x64/lib/python3.10/site-packages/knack/cli.py", line 231, in invoke
2022-04-08T04:22:50.2178068Z     cmd_result = self.invocation.execute(args)
2022-04-08T04:22:50.2178906Z   File "/opt/hostedtoolcache/Python/3.10.4/x64/lib/python3.10/site-packages/azure/cli/core/commands/__init__.py", line 658, in execute
2022-04-08T04:22:50.2179468Z     raise ex
2022-04-08T04:22:50.2180273Z   File "/opt/hostedtoolcache/Python/3.10.4/x64/lib/python3.10/site-packages/azure/cli/core/commands/__init__.py", line 721, in _run_jobs_serially
2022-04-08T04:22:50.2181163Z     results.append(self._run_job(expanded_arg, cmd_copy))
2022-04-08T04:22:50.2182044Z   File "/opt/hostedtoolcache/Python/3.10.4/x64/lib/python3.10/site-packages/azure/cli/core/commands/__init__.py", line 692, in _run_job
2022-04-08T04:22:50.2182655Z     result = cmd_copy(params)
2022-04-08T04:22:50.2183452Z   File "/opt/hostedtoolcache/Python/3.10.4/x64/lib/python3.10/site-packages/azure/cli/core/commands/__init__.py", line 328, in __call__
2022-04-08T04:22:50.2184071Z     return self.handler(*args, **kwargs)
2022-04-08T04:22:50.2184918Z   File "/opt/hostedtoolcache/Python/3.10.4/x64/lib/python3.10/site-packages/azure/cli/core/commands/command_operation.py", line 121, in handler
2022-04-08T04:22:50.2185538Z     return op(**command_args)
2022-04-08T04:22:50.2186357Z   File "/opt/hostedtoolcache/Python/3.10.4/x64/lib/python3.10/site-packages/azure/cli/command_modules/profile/custom.py", line 188, in check_cli
2022-04-08T04:22:50.2187359Z     raise ex
2022-04-08T04:22:50.2188209Z   File "/opt/hostedtoolcache/Python/3.10.4/x64/lib/python3.10/site-packages/azure/cli/command_modules/profile/custom.py", line 183, in check_cli
2022-04-08T04:22:50.2188882Z     create_invoker_and_load_cmds_and_args(cmd.cli_ctx)
2022-04-08T04:22:50.2189785Z   File "/opt/hostedtoolcache/Python/3.10.4/x64/lib/python3.10/site-packages/azure/cli/core/file_util.py", line 74, in create_invoker_and_load_cmds_and_args
2022-04-08T04:22:50.2190464Z     invoker.commands_loader.load_arguments()
2022-04-08T04:22:50.2191301Z   File "/opt/hostedtoolcache/Python/3.10.4/x64/lib/python3.10/site-packages/azure/cli/core/__init__.py", line 512, in load_arguments
2022-04-08T04:22:50.2192165Z     loader.load_arguments('')  # this adds entries to the argument registries
2022-04-08T04:22:50.2193043Z   File "/opt/az/azcliextensions/log-analytics-solution/azext_log_analytics_solution/__init__.py", line 28, in load_arguments
2022-04-08T04:22:50.2193695Z     from azext_log_analytics_solution._params import load_arguments
2022-04-08T04:22:50.2194534Z   File "/opt/az/azcliextensions/log-analytics-solution/azext_log_analytics_solution/_params.py", line 11, in <module>
2022-04-08T04:22:50.2195167Z     from ._validators import validate_workspace_resource_id
2022-04-08T04:22:50.2196031Z   File "/opt/az/azcliextensions/log-analytics-solution/azext_log_analytics_solution/_validators.py", line 7, in <module>
2022-04-08T04:22:50.2196674Z     from azure.mgmt.loganalytics import LogAnalyticsManagementClient
2022-04-08T04:22:50.2197732Z ImportError: cannot import name 'LogAnalyticsManagementClient' from 'azure.mgmt.loganalytics' (/opt/hostedtoolcache/Python/3.10.4/x64/lib/python3.10/site-packages/azure/mgmt/loganalytics/__init__.py)

Not pinning beta versions is a bad idea and can frequently leads to unexpected failures. We have seen similar issues before:

@ghost ghost added Auto-Assign Auto assign by bot CI CI labels Apr 8, 2022
@ghost ghost requested a review from yonzhan April 8, 2022 04:45
@ghost ghost assigned wangzelin007 Apr 8, 2022
@ghost ghost added this to the Apr 2022 (2022-04-26) milestone Apr 8, 2022
@@ -98,7 +98,7 @@
'azure-mgmt-iothubprovisioningservices==1.1.0',
'azure-mgmt-keyvault==9.3.0',
'azure-mgmt-kusto~=0.3.0',
'azure-mgmt-loganalytics~=13.0.0b2',
'azure-mgmt-loganalytics==13.0.0b2',
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#20968 is the first time to use unpinned beta version. @PARADISSEEKR

@jiasli jiasli requested a review from Jing-song April 8, 2022 04:51
@jiasli
Copy link
Member Author

jiasli commented Apr 8, 2022

I have pinned all beta version occurrences. (searched with regex ~=.*b.')

@yonzhan
Copy link
Collaborator

yonzhan commented Apr 8, 2022

CI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot CI CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants