[Storage] Fix #21414: az storage blob sync: Fix the flag --delete-destination default to false
#21662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation default to false
|
Thank you for your contribution jonie001! We will review the pull request and get back to you soon. |
|
Storage bug fix |
az storage blob sync:Fix the flag --delete-destination default to falseaz storage blob sync: Fix the flag --delete-destination default to false
|
Changing the default value is breaking change. How about add a parameter |
…zure-cli into fix_storage_blob_sync
evelyn-ys
reviewed
Mar 21, 2022
| @@ -1256,6 +1259,7 @@ def load_arguments(self, _): # pylint: disable=too-many-locals, too-many-statem | |||
| c.argument('source', options_list=['--source', '-s'], | |||
| help='The source file path to sync from.') | |||
| c.ignore('destination') | |||
| c.argument('delete_destination', delete_destination_type) | |||
There was a problem hiding this comment.
Try to use get_three_state_flag arg type
evelyn-ys
reviewed
Mar 21, 2022
| @@ -81,10 +81,14 @@ def storage_fs_directory_copy(cmd, source, destination, recursive=None, **kwargs | |||
| azcopy.copy(source, destination, flags=flags) | |||
|
|
|||
|
|
|||
| def storage_blob_sync(cmd, client, source, destination, exclude_pattern=None, include_pattern=None, | |||
| exclude_path=None): | |||
| def storage_blob_sync(cmd, client, source, destination, delete_destination=None, exclude_pattern=None, | |||
There was a problem hiding this comment.
Suggested change
| def storage_blob_sync(cmd, client, source, destination, delete_destination=None, exclude_pattern=None, | |
| def storage_blob_sync(cmd, client, source, destination, delete_destination=True, exclude_pattern=None, |
In this way, default=True will automatically show in help message
evelyn-ys
reviewed
Apr 11, 2022
src/azure-cli/azure/cli/command_modules/storage/operations/azcopy.py
Outdated
Show resolved
Hide resolved
evelyn-ys
approved these changes
Apr 11, 2022
az storage blob sync: Fix the flag --delete-destination default to falseaz storage blob sync: Fix the flag --delete-destination default to false
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ation default to false
Description
Fix #21414
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE:
az command a: Make some customer-facing breaking change[Component Name 2]
az command b: Add some customer-facing featureThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.