Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ARM] Fix the exit code of az group deployment validate when the verification fails #11842

Merged
merged 2 commits into from
Jan 19, 2020
Merged

[ARM] Fix the exit code of az group deployment validate when the verification fails #11842

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
009bdaa
Fix the exit code of az group deployment validate when the verificati…
zhoxing-ms Jan 15, 2020
7299994
Merge branch 'dev' into dev3
zhoxing-ms Jan 19, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/azure-cli/HISTORY.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ Release History
**ARM**

* Fix issue #11658: `az group export` command does not support `--query` and `--output` parameters
* Fix issue #10279: The exit code of `az group deployment validate` is 0 when the verification fails

**IoT Central**

Expand Down
5 changes: 4 additions & 1 deletion src/azure-cli/azure/cli/command_modules/resource/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,10 @@ def _deploy_arm_template_core(cli_ctx, resource_group_name,

smc = get_mgmt_service_client(cli_ctx, ResourceType.MGMT_RESOURCE_RESOURCES, aux_subscriptions=aux_subscriptions)
if validate_only:
return sdk_no_wait(no_wait, smc.deployments.validate, resource_group_name, deployment_name, properties)
response = sdk_no_wait(no_wait, smc.deployments.validate, resource_group_name, deployment_name, properties)
if response and response.error:
raise CLIError(response.error)
return response
return sdk_no_wait(no_wait, smc.deployments.create_or_update, resource_group_name, deployment_name, properties)


Expand Down
169 changes: 85 additions & 84 deletions ...cli/azure/cli/command_modules/resource/tests/latest/recordings/test_group_deployment.yaml
View file
Open in desktop

Large diffs are not rendered by default.

Loading