Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SQL] az sql db audit-policy: Fix for empty audit actions and groups #11800

Merged
merged 2 commits into from
Jan 31, 2020
Merged

[SQL] az sql db audit-policy: Fix for empty audit actions and groups #11800

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
11f68e7
In case the policy is enabled and there are no audit actions and grou…
ranisha2 Jan 8, 2020
eaf2f2e
update history
Juliehzl Jan 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/azure-cli/HISTORY.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ Release History

* [BREAKING CHANGE] `az sql db create`: Remove "WideWorldImportersStd" and "WideWorldImportersFull" as documented allowed values for "az sql db create --sample-name". These sample databases would always cause creation to fail.
* Add New commands `sql db classification show/list/update/delete` and `sql db classification recommendation list/enable/disable` to manage sensitivity classifications for SQL databases.
* `az sql db audit-policy`: Fix for empty audit actions and groups

**Storage**

Expand Down
8 changes: 8 additions & 0 deletions src/azure-cli/azure/cli/command_modules/sql/custom.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1434,6 +1434,14 @@ def db_audit_policy_update(
if audit_actions_and_groups:
instance.audit_actions_and_groups = audit_actions_and_groups

# If auditing is enabled, make sure that the actions and groups are set to default
# value in case they were removed previously (When disabling auditing)
if enabled and (not instance.audit_actions_and_groups or instance.audit_actions_and_groups == []):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add test for this scenario?

instance.audit_actions_and_groups = [
"SUCCESSFUL_DATABASE_AUTHENTICATION_GROUP",
"FAILED_DATABASE_AUTHENTICATION_GROUP",
"BATCH_COMPLETED_GROUP"]

if retention_days:
instance.retention_days = retention_days

Expand Down