Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update API Version used by AZCLI for Microsoft.KubernetesConfiguration from 2022-11-01 to 2023-05-01 #26680

Closed
blazepower opened this issue Jun 14, 2023 · 6 comments
Labels

Comments

@blazepower
Copy link

Related command

az k8s-extension create
az k8s-extension update

Resource Provider

Microsoft.KubernetesConfiguration

Description of Feature or Work Requested

Update API version used by AZCLI.

Minimum API Version Required

2023-05-01

Swagger PR link / SDK link

Azure/azure-rest-api-specs#23676

Request Example

https://github.com/Azure/azure-rest-api-specs/blob/60598e96cec040ea9862e89b9f84055dd6386d2c/specification/kubernetesconfiguration/resource-manager/Microsoft.KubernetesConfiguration/stable/2023-05-01/examples/CreateExtension.json

Target Date

ASAP

Additional context

This is a breaking change.

We need to update our API version for our AZCLI commands to version 2023-05-01. This change adds new functionality for our users to support our GA release of Container Marketplace and also contains a breaking change for commands: az k8s-extension create and az k8s-extension update. This breaking change fixes a bug that has caused numerous customer reported incidents since its introduction.

More Information on the Breaking Change:

The Bug

On the installation of our resources, customers are allowed to specify various parameters. Two such parameters, version and autoUpgradeMinorVersion) are conflicting. If version is specified, autoUpgradeMinorVersion MUST be false. We had validation to ensure that these conflicting values were not provided together, but there was a bug with that validation where it was not applied. There was a further bug where if version was specified, the autoUpgradeMinorVersion was ignored. This has led to confusion from customers and instances of our resources not performing as expected.

The Breaking Change

The breaking change we have introduced with API version 2023-05-01 adds the missing validation and we will begin rejecting calls (PUT and PATCH) that provide a version and set autoUpgradeMinorVersion to true.

@yonzhan
Copy link
Collaborator

yonzhan commented Jun 14, 2023

Thank you for opening this issue, we will look into it.

@yonzhan yonzhan added AKS az aks/acs/openshift Service Attention This issue is responsible by Azure service team. labels Jun 14, 2023
@ghost
Copy link

ghost commented Jun 14, 2023

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @Azure/aks-pm.

Issue Details

Related command

az k8s-extension create
az k8s-extension update

Resource Provider

Microsoft.KubernetesConfiguration

Description of Feature or Work Requested

Update API version used by AZCLI.

Minimum API Version Required

2023-05-01

Swagger PR link / SDK link

Azure/azure-rest-api-specs#23676

Request Example

https://github.com/Azure/azure-rest-api-specs/blob/60598e96cec040ea9862e89b9f84055dd6386d2c/specification/kubernetesconfiguration/resource-manager/Microsoft.KubernetesConfiguration/stable/2023-05-01/examples/CreateExtension.json

Target Date

ASAP

Additional context

This is a breaking change.

We need to update our API version for our AZCLI commands to version 2023-05-01. This change adds new functionality for our users to support our GA release of Container Marketplace and also contains a breaking change for commands: az k8s-extension create and az k8s-extension update. This breaking change fixes a bug that has caused numerous customer reported incidents since its introduction.

More Information on the Breaking Change:

The Bug

On the installation of our resources, customers are allowed to specify various parameters. Two such parameters, version and autoUpgradeMinorVersion) are conflicting. If version is specified, autoUpgradeMinorVersion MUST be false. We had validation to ensure that these conflicting values were not provided together, but there was a bug with that validation where it was not applied. There was a further bug where if version was specified, the autoUpgradeMinorVersion was ignored. This has led to confusion from customers and instances of our resources not performing as expected.

The Breaking Change

The breaking change we have introduced with API version 2023-05-01 adds the missing validation and we will begin rejecting calls (PUT and PATCH) that provide a version and set autoUpgradeMinorVersion to true.

Author: blazepower
Assignees: -
Labels:

Service Attention, AKS, feature-request

Milestone: -

@ghost
Copy link

ghost commented Jun 14, 2023

Thanks for the feedback! We are routing this to the appropriate team for follow-up. cc @NarayanThiru.

Issue Details

Related command

az k8s-extension create
az k8s-extension update

Resource Provider

Microsoft.KubernetesConfiguration

Description of Feature or Work Requested

Update API version used by AZCLI.

Minimum API Version Required

2023-05-01

Swagger PR link / SDK link

Azure/azure-rest-api-specs#23676

Request Example

https://github.com/Azure/azure-rest-api-specs/blob/60598e96cec040ea9862e89b9f84055dd6386d2c/specification/kubernetesconfiguration/resource-manager/Microsoft.KubernetesConfiguration/stable/2023-05-01/examples/CreateExtension.json

Target Date

ASAP

Additional context

This is a breaking change.

We need to update our API version for our AZCLI commands to version 2023-05-01. This change adds new functionality for our users to support our GA release of Container Marketplace and also contains a breaking change for commands: az k8s-extension create and az k8s-extension update. This breaking change fixes a bug that has caused numerous customer reported incidents since its introduction.

More Information on the Breaking Change:

The Bug

On the installation of our resources, customers are allowed to specify various parameters. Two such parameters, version and autoUpgradeMinorVersion) are conflicting. If version is specified, autoUpgradeMinorVersion MUST be false. We had validation to ensure that these conflicting values were not provided together, but there was a bug with that validation where it was not applied. There was a further bug where if version was specified, the autoUpgradeMinorVersion was ignored. This has led to confusion from customers and instances of our resources not performing as expected.

The Breaking Change

The breaking change we have introduced with API version 2023-05-01 adds the missing validation and we will begin rejecting calls (PUT and PATCH) that provide a version and set autoUpgradeMinorVersion to true.

Author: blazepower
Assignees: -
Labels:

Service Attention, Breaking Change, AKS, Kubernetes Configuration, feature-request

Milestone: -

@yonzhan yonzhan removed the AKS az aks/acs/openshift label Jun 14, 2023
@blazepower
Copy link
Author

@yonzhan any update as to when we will receive a follow-up?

@bavneetsingh16
Copy link

The api version '2023-05-01' is updated in 'k8s-extension' version 1.5.0. Please update the cli extension using the below cmd:

az extension update --name k8s-extension

@bavneetsingh16
Copy link

Closing this issue as the resolution steps are provided above.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants