[ARM] Fix the exit code of az group deployment validate when the veri…

…fication fails (#11842)
Azure · Jan 19, 2020 · b1cf183 · b1cf183
1 parent bd78e5f
commit b1cf183
Show file tree

Hide file tree

Showing 6 changed files with 227 additions and 128 deletions.
diff --git a/src/azure-cli/HISTORY.rst b/src/azure-cli/HISTORY.rst
@@ -14,6 +14,7 @@ Release History
 **ARM**
 
 * Fix issue #11658: `az group export` command does not support `--query` and `--output` parameters
+* Fix issue #10279: The exit code of `az group deployment validate` is 0 when the verification fails
 
 **IoT Central**
 

diff --git a/src/azure-cli/azure/cli/command_modules/resource/custom.py b/src/azure-cli/azure/cli/command_modules/resource/custom.py
@@ -285,7 +285,10 @@ def _deploy_arm_template_core(cli_ctx, resource_group_name,
 
     smc = get_mgmt_service_client(cli_ctx, ResourceType.MGMT_RESOURCE_RESOURCES, aux_subscriptions=aux_subscriptions)
     if validate_only:
-        return sdk_no_wait(no_wait, smc.deployments.validate, resource_group_name, deployment_name, properties)
+        response = sdk_no_wait(no_wait, smc.deployments.validate, resource_group_name, deployment_name, properties)
+        if response and response.error:
+            raise CLIError(response.error)
+        return response
     return sdk_no_wait(no_wait, smc.deployments.create_or_update, resource_group_name, deployment_name, properties)
 
 

diff --git a/...cli/azure/cli/command_modules/resource/tests/latest/recordings/test_group_deployment.yaml b/...cli/azure/cli/command_modules/resource/tests/latest/recordings/test_group_deployment.yaml
-Original file line number
+Diff line change
@@ Expand Up / @@ -14,6 +14,7 @@ Release History @@
     **ARM**
     * Fix issue #11658: `az group export` command does not support `--query` and `--output` parameters
+    * Fix issue #10279: The exit code of `az group deployment validate` is 0 when the verification fails
     **IoT Central**
@@ Expand Down @@