Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AzureFirewall] az network firewall policy: Add param --explicit-proxy #7164

Merged
merged 5 commits into from
Jan 15, 2024

Conversation

ZengTaoxu
Copy link
Contributor


closed: Azure/azure-cli#27581
This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)
  • My extension version conforms to the Extension version schema

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

Copy link

azure-client-tools-bot-prd bot commented Jan 9, 2024

⚠️Azure CLI Extensions Breaking Change Test
⚠️azure-firewall
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd network firewall create cmd network firewall create added parameter enable_explicit_proxy
⚠️ 1006 - ParaAdd network firewall create cmd network firewall create added parameter enable_pac_file
⚠️ 1006 - ParaAdd network firewall create cmd network firewall create added parameter http_port
⚠️ 1006 - ParaAdd network firewall create cmd network firewall create added parameter https_port
⚠️ 1006 - ParaAdd network firewall create cmd network firewall create added parameter pac_file_port
⚠️ 1006 - ParaAdd network firewall create cmd network firewall create added parameter pac_file
⚠️ 1006 - ParaAdd network firewall policy create cmd network firewall policy create added parameter explicit_proxy
⚠️ 1006 - ParaAdd network firewall policy intrusion-detection add cmd network firewall policy intrusion-detection add added parameter explicit_proxy
⚠️ 1006 - ParaAdd network firewall policy intrusion-detection remove cmd network firewall policy intrusion-detection remove added parameter explicit_proxy
⚠️ 1006 - ParaAdd network firewall policy update cmd network firewall policy update added parameter explicit_proxy

Copy link

Hi @ZengTaoxu,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Collaborator

yonzhan commented Jan 9, 2024

AzureFirewall

@microsoft-github-policy-service microsoft-github-policy-service bot added the Auto-Assign Auto assign by bot label Jan 9, 2024
@ZengTaoxu ZengTaoxu changed the title [AzureFirewall] az network firewall policy: Support Explicit Proxy feature [AzureFirewall] az network firewall policy: Add param --explicit-proxy Jan 9, 2024
@necusjz
Copy link
Member

necusjz commented Jan 15, 2024

please update the changelog and setup.py as well

@necusjz necusjz merged commit 6c96c5c into Azure:main Jan 15, 2024
14 checks passed
@azclibot
Copy link
Collaborator

[Release] Update index.json for extension [ azure-firewall ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=121852&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot Network
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Explicit Proxy feature for Azure Firewall Policy
4 participants