Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Containerapp 0.3.6 release #4879

Merged
merged 17 commits into from
Jun 8, 2022
Merged

Conversation

StrawnSC
Copy link
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.

@ghost ghost requested a review from yonzhan May 23, 2022 21:25
@ghost ghost added the Auto-Assign Auto assign by bot label May 23, 2022
@ghost ghost requested a review from wangzelin007 May 23, 2022 21:25
@ghost ghost assigned zhoxing-ms May 23, 2022
@ghost ghost added this to the Jun 2022 (2022-07-05) milestone May 23, 2022
@ghost ghost added the ContainerApp label May 23, 2022
@ghost ghost requested review from zhoxing-ms and jsntcy May 23, 2022 21:25
@yonzhan
Copy link
Collaborator

yonzhan commented May 23, 2022

Containerapp

runefa and others added 6 commits May 25, 2022 13:44
* Added environment as flag for list_containerapp.

* Fixed logic error in RID case.

* Check if rg exists.

* Validate managed env exists if group is passed or rid is passed.

Co-authored-by: Haroon Feisal <haroonfeisal@microsoft.com>
* Integer division to update existing weights. Validate revision names.

* Added revision label add ability to reuse existing label.

* Fixed style issues.

* Removed deprecated _round function in utils.

* Added revision label swap.

* Revision list only shows active revisions by default. Use flag --all to show inactive revisions as well.

* Updated history.

* Changed to use --labels instead of label1,label2. Added util to check if traffic payload less than 4096 bytes.

* Added label check in traffic set.

* Updated history.

* Removed 4096byte util.

* Added help for label swap, fixed styling.

* Added test for revision labels. Fixed help typo.

Co-authored-by: Haroon Feisal <haroonfeisal@microsoft.com>
* Updated enum.

* Updated history.

Co-authored-by: Haroon Feisal <haroonfeisal@microsoft.com>
* Updated error handling.

* Made sure key retrieval had a try catch.

* Added error handling for --logs-customer-id only case.

* Updated error handling of _ensure_location_allowed.

* Default providers_client to None.

Co-authored-by: Haroon Feisal <haroonfeisal@microsoft.com>
* Fix microsoft/azure-container-apps#234

* Added history note.

Co-authored-by: Haroon Feisal <haroonfeisal@microsoft.com>
Co-authored-by: Haroon Feisal <38823870+haroonf@users.noreply.github.com>
lil131 and others added 2 commits June 6, 2022 11:32
* show api error message for invalid cert name

* hide prompt as default & surface api response

* rename --prompt

* added BREAKING CHANGE bullet to history.rst

Co-authored-by: Haroon Feisal <38823870+haroonf@users.noreply.github.com>
@StrawnSC StrawnSC marked this pull request as ready for review June 6, 2022 16:48
Copy link
Contributor

@panchagnula panchagnula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few requests

lil131 and others added 6 commits June 6, 2022 16:16
…rce, --target. (#123)

* Changed --labels to --source-label, target-label.

* Dropped -label from params in label swap.

Co-authored-by: Haroon Feisal <haroonfeisal@microsoft.com>
MSI auth for `az containerapp registry set`
@StrawnSC StrawnSC requested a review from panchagnula June 7, 2022 00:57
@panchagnula
Copy link
Contributor

@zhoxing-ms can we get your initial review as well, so we can ship these changes soon. Thanks!

@StrawnSC StrawnSC requested a review from zhoxing-ms June 7, 2022 05:50
Copy link
Contributor

@panchagnula panchagnula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhoxing-ms zhoxing-ms merged commit 465ed40 into Azure:main Jun 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auto-Assign Auto assign by bot ContainerApp
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants