Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

{AKS} Add v2 agentpool decorator #4748

Merged
merged 9 commits into from
May 5, 2022

Conversation

FumingZhang
Copy link
Member


This checklist is used to make sure that common guidelines for a pull request are followed.

  • Add v2 agentpool decorator
  • Sort out params, deprecate option --node-zones, replace with --zones

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@ghost ghost requested review from zhoxing-ms and wangzelin007 April 28, 2022 09:05
@ghost ghost assigned zhoxing-ms Apr 28, 2022
@ghost ghost added this to the May 2022 (2022-05-24) milestone Apr 28, 2022
@ghost ghost added the Auto-Assign Auto assign by bot label Apr 28, 2022
@ghost ghost requested a review from yonzhan April 28, 2022 09:05
@ghost ghost added the AKS label Apr 28, 2022
@yonzhan
Copy link
Collaborator

yonzhan commented Apr 28, 2022

AKS

@FumingZhang FumingZhang force-pushed the fuming/agentpool-decorator-v2 branch from 5477db7 to e3e7a83 Compare April 29, 2022 02:52
@FumingZhang FumingZhang marked this pull request as ready for review May 5, 2022 03:27
@FumingZhang FumingZhang requested a review from andyliuliming as a code owner May 5, 2022 03:27
@zhoxing-ms zhoxing-ms merged commit a379919 into Azure:main May 5, 2022
@FumingZhang FumingZhang deleted the fuming/agentpool-decorator-v2 branch May 16, 2022 02:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AKS Auto-Assign Auto assign by bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants