Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore pdb #4718

Merged
merged 10 commits into from Apr 29, 2022
Merged

Ignore pdb #4718

merged 10 commits into from Apr 29, 2022

Conversation

ghost
Copy link

@ghost ghost commented Apr 21, 2022


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@ghost ghost requested review from andyliuliming and FumingZhang as code owners April 21, 2022 19:56
@yonzhan
Copy link
Collaborator

yonzhan commented Apr 21, 2022

aks

Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update the recordings for cases including aks nodepool delete, since the PR has changed the signature of the command.

Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ghost ghost requested a review from zhoxing-ms April 27, 2022 00:39
@ghost ghost requested a review from zhoxing-ms April 28, 2022 07:05
@zhoxing-ms zhoxing-ms merged commit eef9caf into Azure:main Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants