Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AKS] Implement workload identity support #4685

Merged
merged 13 commits into from
Apr 19, 2022

Conversation

bcho
Copy link
Member

@bcho bcho commented Apr 15, 2022

This pull request implemented workload identity enablement support for aks.

$ az aks create --enable-workload-identity
$ az aks update --enable-workload-identity
$ az aks update --disable-workload-identity

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@ghost ghost requested review from zhoxing-ms and wangzelin007 April 15, 2022 06:51
@ghost ghost assigned zhoxing-ms Apr 15, 2022
@ghost ghost added this to the Apr 2022 (2022-04-26) milestone Apr 15, 2022
@ghost ghost added the Auto-Assign Auto assign by bot label Apr 15, 2022
@ghost ghost requested a review from yonzhan April 15, 2022 06:52
@ghost ghost added the AKS label Apr 15, 2022
@yonzhan
Copy link
Collaborator

yonzhan commented Apr 15, 2022

AKS

@bcho bcho marked this pull request as ready for review April 18, 2022 10:10
@bcho bcho changed the title [WIP] Aks/enable workload idenitty [AKS] Implement workload identity support Apr 18, 2022
@bcho bcho requested a review from FumingZhang April 19, 2022 01:39
Copy link
Member

@FumingZhang FumingZhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhoxing-ms zhoxing-ms merged commit f48a0fe into Azure:main Apr 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AKS Auto-Assign Auto assign by bot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants