[k8s-configuration] Bump pycryptodome to support Python 3.10
#4643
Conversation
src/k8sconfiguration/setup.py
Outdated
| @@ -33,7 +33,7 @@ | |||
| ] | |||
|
|
|||
| # TODO: Add any additional SDK dependencies here | |||
| DEPENDENCIES = ["pycryptodome~=3.9.8"] | |||
| DEPENDENCIES = ["pycryptodome~=3.14.1"] | |||
There was a problem hiding this comment.
If k8sconfiguration is deprecated:
azure-cli-extensions/src/k8sconfiguration/HISTORY.rst
Lines 6 to 8 in 8910046
We should remove it.
There was a problem hiding this comment.
In fact, the description here should mean to deprecate/hide the k8sconfiguration command group and replace it with k8s-configuration command group.
PR link
@jonathan-innis Could please you confirm it? If so, please add specific information to the description to avoid ambiguity and confusion
There was a problem hiding this comment.
Yes, k8sconfiguration has been fully deprecated and we would like to remove it. @zhoxing-ms, do you want me to remove the extension? For this pycryptodome change, this change looks good and can be merged
There was a problem hiding this comment.
@jonathan-innis OK, if you are sure that most users have been migrated from k8sconfiguration extension to k8s-configuration extension, please remove it.
In addition, the Build Event (May 24-26) is one of the window periods for CLI to launch batch breaking changes, which is a good opportunity for removing this extension
There was a problem hiding this comment.
I only mean removing the source code. The released extension whls won't be deleted.
There was a problem hiding this comment.
If the original extension is no longer used by users, I personally suggest that we can also consider removing them from index.json, so as to avoid too much contents in the index.json file
|
Bump pycryptodome |
pycryptodome to support Python 3.10pycryptodome to support Python 3.10
|
|
pycryptodome to support Python 3.10pycryptodome to support Python 3.10
Fix Azure/azure-cli#21964
MSI's bundled Python has been updated to 3.10 (Azure/azure-cli#21746).
k8s-configurationandconnectedk8sdepend onpycryptodome==3.9.8which doesn't release wheels for Python 3.10:https://pypi.org/project/pycryptodome/3.9.8/#files
The latest
pycryptodome3.14.1 works with Python 3.10 using ABIs:https://pypi.org/project/pycryptodome/#files