SCVMM Extension for Public Preview

[nascarsayan]

---

This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

• Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
• Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

• My extension description/summary conforms to the Extension Summary Guidelines.

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

[yonzhan]

SCVMM

[nascarsayan]

Hi @kairu-ms , the build is failing with this error:

ModuleNotFoundError: No module named 'azure_devtools'

Is it some issue with the PR?

python -m unittest discover -v <path-to-repo>/src/scvmm is passing locally

[nascarsayan]

I understood the issue. It was with this line:
from azure_devtools.scenario_tests import AllowLargeResponse
I have removed this line, it should work now.

In my local environment from azure.cli.testsdk.scenario_tests import AllowLargeResponse is not working.

[subbartt]

@kairu-ms , we are targeting to publish the az cli by end of April, let us know if there is any feedback so that we can incorporate.

[kairu-ms]

Please add "wait" commands for this command group. For example:

azure-cli-extensions/src/front-door/azext_front_door/commands.py

Line 78 in aa0d22e

g.wait_command('wait')

[nascarsayan]

Have added wait command everywhere. I had to change the scvmm vm-template wait command to custom_wait_command, because --virtual-machine-template-name parameter was exceeding the max length of parameter (azdev linter was failing). Any suggestions if we could rename the parameter in the wait command without using custom wait?

[kairu-ms]

Hi @nascarsayan, you can suppress the max length of parameter linter validation by adding a linter_exclusions.yml file. For example:

azure-cli-extensions/src/datafactory/linter_exclusions.yml

Lines 1 to 5 in 6bb827f

	datafactory get-git-hub-access-token:
	parameters:
	git_hub_access_token_base_url:
	rule_exclusions:
	- option_length_too_long

[kairu-ms]

Hi @nascarsayan, another way is that you can use options_list property of argument to provide a short name instead of --virtual-machine-template-name, for example:

azure-cli-extensions/src/datafactory/azext_datafactory/manual/_params.py

Lines 20 to 22 in 6bb827f

	c.argument('factory_vsts_configuration', options_list=['--vsts-config', '--factory-vsts-configuration'],
	action=AddFactoryVstsConfiguration, nargs='+', help='Factory\'s VSTS repo information.',
	arg_group='RepoConfiguration')

[nascarsayan]

Hi @kairu-ms, I've used options_list to use a shorter name for the param. Thanks for the references.

One question: We don't have a wait on a particular disk/nic of the VM, is that fine? The wait we are providing for scvmm vm disk / scvmm vm nic is the same as for scvmm vm.
These command groups use VirtualMachinesOperations under the hood, i.e., there's no separate client_factory for them.

[kairu-ms]

I see, that’s ok

[kairu-ms]

@kairu-ms , we are targeting to publish the az cli by end of April, let us know if there is any feedback so that we can incorporate.

Please ping me when above comments resolved. I will help you to release extension on time.