-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dataprotection] Onboard new RP Dataprotection to azure-cli-extensions #3459
Conversation
Dataprotection |
df18632
to
fa9875d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is UpgradeLog.htm used for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some arguments such as --properties and --parameters are huge. I think you should flatten them. Please follow the link to config codegen.
@kairu-ms we have 2 command that expects parameters (since it is autogenerated). Our API request payload is quite complex and hence we decided to have separate initialize command to construct the request body and use the autogenerated command as it is to do the service request. Our initialize cmd will give a json output. User can save it in json file and give the filename as input to the commands which expects --parameters. Hope this clarifies |
This checklist is used to make sure that common guidelines for a pull request are followed.
General Guidelines
azdev style <YOUR_EXT>
locally? (pip install azdev
required)python scripts/ci/test_index.py -q
locally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update
src/index.json
automatically.The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify
src/index.json
.