Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dataprotection] Onboard new RP Dataprotection to azure-cli-extensions #3459

Merged
merged 12 commits into from
Jun 9, 2021

Conversation

sambitratha
Copy link
Contributor

@sambitratha sambitratha commented Jun 3, 2021


This checklist is used to make sure that common guidelines for a pull request are followed.

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your PR is merged into master branch, a new PR will be created to update src/index.json automatically.
The precondition is to put your code inside this repo and upgrade the version in the PR but do not modify src/index.json.

@yonzhan
Copy link
Collaborator

yonzhan commented Jun 3, 2021

Dataprotection

@yonzhan yonzhan requested review from 00Kai0, kairu-ms and jsntcy June 3, 2021 14:16
@yonzhan yonzhan added this to the S188 milestone Jun 3, 2021
@sambitratha sambitratha changed the title [InProgress] Onboard new RP Dataprotection to azure-cli-extensions [Dataprotection] Onboard new RP Dataprotection to azure-cli-extensions Jun 7, 2021
Copy link
Contributor

@kairu-ms kairu-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is UpgradeLog.htm used for?

Copy link
Contributor

@kairu-ms kairu-ms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some arguments such as --properties and --parameters are huge. I think you should flatten them. Please follow the link to config codegen.

@sambitratha
Copy link
Contributor Author

@kairu-ms we have 2 command that expects parameters (since it is autogenerated). Our API request payload is quite complex and hence we decided to have separate initialize command to construct the request body and use the autogenerated command as it is to do the service request. Our initialize cmd will give a json output. User can save it in json file and give the filename as input to the commands which expects --parameters. Hope this clarifies

@kairu-ms kairu-ms merged commit d2e621b into Azure:master Jun 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants