Fix SEGFAULT errors introduced by dns_resolver in socketio (gh# 1275) #415
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relates to: Azure/azure-iot-sdk-c#1275 There were two instances of possible failures not properly handled on socketio related to dns_resolver: - The result of dns_resolver_create() was not being checked for NULL (which could be caused by memory allocation failure); - The result of dns_resolver_get_addrInfo() was not being checked for NULL, which could happen even if dns_resolver_is_lookup_complete returned true. These failures affected socketio_berkeley.c and socketio_win32.c. The currently remaining socketio implementations were not affected, since they do not use dns_resolver (socketio_mbed.c, socketio_mbed_os5.c). Thanks @mlilien for the initial PR to fix this issue.
jebrando
reviewed
Nov 21, 2019
jspaith
reviewed
Nov 21, 2019
jspaith
reviewed
Nov 21, 2019
hihigupt
reviewed
Nov 21, 2019
hihigupt
reviewed
Nov 21, 2019
hihigupt
reviewed
Nov 21, 2019
danewalton-msft
approved these changes
Nov 21, 2019
f78710e to
40a4e53
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to: Azure/azure-iot-sdk-c#1275
There were two instances of possible failures not properly handled on socketio related to dns_resolver:
These failures affected socketio_berkeley.c and socketio_win32.c.
The currently remaining socketio implementations were not affected, since they do not use dns_resolver (socketio_mbed.c, socketio_mbed_os5.c).
Thanks @mlilien for the initial PR to fix this issue.