Modular generation for typespec-todo #2927
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
timovv
commented
Nov 25, 2024
•
- support tcgc type for ModelProperty
- remove baseUrl in unbranded client
- remove property if visibility with none.
timovv
commented
Nov 25, 2024
|
|
||
| // @public (undocumented) | ||
| export interface TodoItemsUpdateBodyParam { | ||
| create: (item: TodoItem, options?: TodoItemsCreateOptionalParams) => Promise<{ |
There was a problem hiding this comment.
Response is an anonymous model but should be a reference to the named model? investigate
There was a problem hiding this comment.
This happens in quite a few places
There was a problem hiding this comment.
This is because of there is an @visibilty(create) and this caused we failed to get effective model there, if the visibility create is removed, this should be fixed.
Confirmed with Renhe as below
No need to support visibility create for now. The spec will be updated.
...ges/typespec-test/test/todo_non_branded/generated/typespec-ts/review/todo-non-branded.api.md
Outdated
Show resolved
Hide resolved
...ges/typespec-test/test/todo_non_branded/generated/typespec-ts/review/todo-non-branded.api.md
Show resolved
Hide resolved
...ges/typespec-test/test/todo_non_branded/generated/typespec-ts/review/todo-non-branded.api.md
Show resolved
Hide resolved
timovv
commented
Nov 25, 2024
| model TodoItem { | ||
| /** The item's unique id */ | ||
| @key id: safeint; | ||
| @visibility("read") @key id: safeint; |
There was a problem hiding this comment.
@visibility not respected
There was a problem hiding this comment.
read-only should be respected and this is the only case we supported now(codegen code).
MaryGao
reviewed
Nov 27, 2024
...spec-test/test/todo_non_branded/generated/typespec-ts/src/api/todoItems/attachments/index.ts
Show resolved
Hide resolved
Closed
MaryGao
reviewed
Nov 27, 2024
...ges/typespec-test/test/todo_non_branded/generated/typespec-ts/review/todo-non-branded.api.md
Outdated
Show resolved
Hide resolved
MaryGao
approved these changes
Dec 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.