Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove uglify-js dep generation for autorest.typescript #2920

Merged
merged 7 commits into from
Nov 22, 2024
Merged

Remove uglify-js dep generation for autorest.typescript #2920

merged 7 commits into from
Nov 22, 2024

Conversation

kazrael2119
Copy link
Contributor

@kazrael2119 kazrael2119 commented Nov 21, 2024 •
edited
Loading

fixes #2910

@kazrael2119 kazrael2119 marked this pull request as ready for review November 21, 2024 02:06
@kazrael2119
Copy link
Contributor Author

@jeremymeng please help review thanks

jeremymeng
jeremymeng approved these changes Nov 21, 2024
View reviewed changes
Copy link
Member

@jeremymeng jeremymeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the fix!

@qiaozha qiaozha enabled auto-merge (squash) November 22, 2024 06:16
@qiaozha qiaozha merged commit 1364189 into Azure:main Nov 22, 2024
15 checks passed
@kazrael2119 kazrael2119 deleted the remove-uglify-js-dep branch November 22, 2024 06:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qiaozha qiaozha qiaozha approved these changes

@jeremymeng jeremymeng jeremymeng approved these changes

@sarangan12 sarangan12 Awaiting requested review from sarangan12 sarangan12 is a code owner

@joheredi joheredi Awaiting requested review from joheredi joheredi is a code owner

@MaryGao MaryGao Awaiting requested review from MaryGao MaryGao is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Shall we remove "uglify-js" dependency in codegen package.json generator?
3 participants
@kazrael2119 @jeremymeng @qiaozha